From: "Mylène Josserand" <mylene.josserand@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
michael@amarulasolutions.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, tiwai@suse.com,
lgirdwood@gmail.com, robh+dt@kernel.org,
thomas.petazzoni@bootlin.com
Subject: Re: [PATCH v2 1/2] ASoC: codecs: Add support for PCM1789
Date: Wed, 7 Mar 2018 15:34:49 +0100 [thread overview]
Message-ID: <20180307153449.18769094@dell-desktop.home> (raw)
In-Reply-To: <20180305155938.GL8588@sirena.org.uk>
Hello Mark,
Thanks for the review.
On Mon, 5 Mar 2018 15:59:38 +0000
Mark Brown <broonie@kernel.org> wrote:
> On Mon, Mar 05, 2018 at 04:57:15PM +0100, Alexandre Belloni wrote:
> > On 05/03/2018 at 15:49:10 +0000, Mark Brown wrote:
>
> > > Please don't mix C and C++ style comments in a single comment like this
> > > - it looks unintentional. Just use the same style for the whole thing.
> > > You also don't need to include all the boilerplate with the SPDX header.
>
> > I think Linus made it clear that he wants the SPDX header to be a
> > C++ comment, the documentation has:
>
> Sure, so make the entire thing a C++ comment then.
Ok, I saw other drivers with this mix C++/C comment code so I wrote it
like this but no problem using only C++ comment.
I will send a v3 with this modification only (except if I have other
reviews).
Best regards,
--
Mylène Josserand, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2018-03-07 14:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 12:48 [PATCH v2 0/2] ASoC: Add support for DAC PCM1789 Mylène Josserand
2018-03-05 12:48 ` [PATCH v2 1/2] ASoC: codecs: Add support for PCM1789 Mylène Josserand
2018-03-05 15:49 ` Mark Brown
2018-03-05 15:57 ` Alexandre Belloni
2018-03-05 15:59 ` Mark Brown
2018-03-07 14:34 ` Mylène Josserand [this message]
2018-03-05 12:48 ` [PATCH v2 2/2] ASoC: Add bindings " Mylène Josserand
2018-03-07 22:30 ` Rob Herring
2018-03-08 8:54 ` Mylène Josserand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307153449.18769094@dell-desktop.home \
--to=mylene.josserand@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael@amarulasolutions.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).