From: "Mylène Josserand" <mylene.josserand@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, michael@amarulasolutions.com,
alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org,
tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org,
thomas.petazzoni@bootlin.com
Subject: Re: [PATCH v2 2/2] ASoC: Add bindings for PCM1789
Date: Thu, 8 Mar 2018 09:54:40 +0100 [thread overview]
Message-ID: <20180308095440.515458eb@dell-desktop.home> (raw)
In-Reply-To: <20180307223048.lqnryaazr5egg2m7@rob-hp-laptop>
Hello Rob,
Thank you for the review.
On Wed, 7 Mar 2018 16:30:48 -0600
Rob Herring <robh@kernel.org> wrote:
> On Mon, Mar 05, 2018 at 01:48:17PM +0100, Mylène Josserand wrote:
> > Add a device-tree binding for Texas Instrument's PCM1789 codec.
> > For the moment, only I2C bus is supported but SPI could be added
> > in future.
> >
> > Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com>
> > ---
> > Documentation/devicetree/bindings/sound/pcm1789.txt | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/pcm1789.txt
> >
> > diff --git a/Documentation/devicetree/bindings/sound/pcm1789.txt b/Documentation/devicetree/bindings/sound/pcm1789.txt
> > new file mode 100644
> > index 000000000000..a6cdc2c83c98
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/pcm1789.txt
> > @@ -0,0 +1,21 @@
> > +Texas Instruments pcm1789 DT bindings
>
> What function does this device provide?
Sorry, I forgot to mention this information.
>
> > +
> > +This driver supports the I2C bus.
>
> Bindings describe h/w, not drivers.
True, I will reformulate it.
>
> > +
> > +Required properties:
> > +
> > + - compatible: "ti,pcm1789"
> > +
> > +Required properties on I2C:
> > +
> > + - reg: the I2C address
> > + - reset-gpios: GPIO to control the RESET pin
> > +
> > +Examples:
> > +
> > + codec: pcm1789@4c {
>
> audio-codec@4c
>
> If that's the function...
Yep, I will change that.
>
> > + compatible = "ti,pcm1789";
> > + reg = <0x4c>;
> > + reset-gpios = <&gpio2 14 GPIO_ACTIVE_LOW>;
> > + #sound-dai-cells = <0>;
> > + };
> > --
> > 2.11.0
> >
Thanks,
Best regards,
--
Mylène Josserand, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2018-03-08 8:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 12:48 [PATCH v2 0/2] ASoC: Add support for DAC PCM1789 Mylène Josserand
2018-03-05 12:48 ` [PATCH v2 1/2] ASoC: codecs: Add support for PCM1789 Mylène Josserand
2018-03-05 15:49 ` Mark Brown
2018-03-05 15:57 ` Alexandre Belloni
2018-03-05 15:59 ` Mark Brown
2018-03-07 14:34 ` Mylène Josserand
2018-03-05 12:48 ` [PATCH v2 2/2] ASoC: Add bindings " Mylène Josserand
2018-03-07 22:30 ` Rob Herring
2018-03-08 8:54 ` Mylène Josserand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308095440.515458eb@dell-desktop.home \
--to=mylene.josserand@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael@amarulasolutions.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).