From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: ALSA <alsa-devel@alsa-project.org>,
tiwai@suse.de, Greg KH <gregkh@linuxfoundation.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
Shreyas NC <shreyas.nc@intel.com>
Subject: Re: [PATCH v3 08/13] ASoC: Add SoundWire stream programming interface
Date: Tue, 17 Apr 2018 21:19:05 +0530 [thread overview]
Message-ID: <20180417154904.GY6014@localhost> (raw)
In-Reply-To: <20180417111118.GF8973@sirena.org.uk>
On Tue, Apr 17, 2018 at 12:11:18PM +0100, Mark Brown wrote:
> On Mon, Apr 16, 2018 at 08:53:36PM +0530, Vinod Koul wrote:
>
> > +/**
> > + * snd_soc_dai_set_sdw_stream() - Configures a DAI for SDW stream operation
> > + * @dai: DAI
> > + * @stream: STREAM
> > + * @direction: Stream direction(Playback/Capture)
> > + * SoundWire subsystem doesn't have a notion of direction and we reuse
> > + * the ASoC stream direction to configure source/sink ports.
> > + *
> > + * Returns 0 on success, a negative error code otherwise.
> > + */
> > +static inline int snd_soc_dai_set_sdw_stream(struct snd_soc_dai *dai,
> > + void *stream, int direction)
> > +{
>
> How do we clear the stream that's been set up? I'd expect that to be a
> useful thing to do from a housekeeping point of view if nothing else.
Right it needs to be cleared and that is achieved by setting with NULL.
Thanks
--
~Vinod
next prev parent reply other threads:[~2018-04-17 15:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 15:23 [PATCH v3 00/13] soundwire: Add stream support Vinod Koul
2018-04-16 15:23 ` [PATCH v3 01/13] Documentation: soundwire: Add more documentation Vinod Koul
2018-04-16 15:23 ` [PATCH v3 02/13] soundwire: Add support for SoundWire stream management Vinod Koul
2018-04-16 23:15 ` Pierre-Louis Bossart
2018-04-17 3:46 ` Vinod Koul
2018-04-16 15:23 ` [PATCH v3 03/13] soundwire: Add support for port management Vinod Koul
2018-04-16 23:30 ` Pierre-Louis Bossart
2018-04-17 4:11 ` Vinod Koul
2018-04-16 15:23 ` [PATCH v3 04/13] soundwire: Add Master and Slave port programming Vinod Koul
2018-04-16 15:23 ` [PATCH v3 05/13] soundwire: Add helpers for ports operations Vinod Koul
2018-04-16 15:23 ` [PATCH v3 06/13] soundwire: Add bank switch routine Vinod Koul
2018-04-16 15:23 ` [PATCH v3 07/13] soundwire: Add stream configuration APIs Vinod Koul
2018-04-16 15:23 ` [PATCH v3 08/13] ASoC: Add SoundWire stream programming interface Vinod Koul
2018-04-16 23:42 ` Pierre-Louis Bossart
2018-04-17 11:11 ` Mark Brown
2018-04-17 15:49 ` Vinod Koul [this message]
2018-04-16 15:23 ` [PATCH v3 09/13] soundwire: Remove cdns_master_ops Vinod Koul
2018-04-16 15:23 ` [PATCH v3 10/13] soundwire: cdns: Add port routines Vinod Koul
2018-04-16 15:23 ` [PATCH v3 11/13] soundwire: cdns: Add stream routines Vinod Koul
2018-04-16 15:23 ` [PATCH v3 12/13] soundwire: intel: Add stream initialization Vinod Koul
2018-04-16 15:23 ` [PATCH v3 13/13] soundwire: intel: Add audio DAI ops Vinod Koul
2018-04-17 0:00 ` [PATCH v3 00/13] soundwire: Add stream support Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417154904.GY6014@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shreyas.nc@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).