From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org,
Shreyas NC <shreyas.nc@intel.com>
Subject: Re: [PATCH v3 3/3] ASoC: Add Multi CPU DAI support in DAPM
Date: Mon, 30 Apr 2018 17:24:56 +0100 [thread overview]
Message-ID: <20180430162456.34232lvulubgp5ky@localhost.localdomain> (raw)
In-Reply-To: <1524131359-24387-4-git-send-email-vinod.koul@intel.com>
On Thu, Apr 19, 2018 at 03:19:19PM +0530, Vinod Koul wrote:
> From: Shreyas NC <shreyas.nc@intel.com>
>
> Extend the multi CPU support in DAPM functions to check for
> valid widgets and connected widgets.
>
> Signed-off-by: Shreyas NC <shreyas.nc@intel.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> ---
> +static void dapm_add_valid_dai_widget(struct snd_soc_card *card,
> + struct snd_soc_pcm_runtime *rtd,
> + struct snd_soc_dai *codec_dai,
> + struct snd_soc_dai *cpu_dai)
This function name still feels a little funny since the function
doesn't add any widgets. It adds paths if there are valid
widgets. Perhaps dapm_add_valid_dai_path?
But I don't feel super strongly about it, so:
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2018-04-30 16:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 9:49 [PATCH v3 0/3] ASoC: Add Multi CPU DAI support Vinod Koul
2018-04-19 9:49 ` [PATCH v3 1/3] ASoC: Add initial support for multiple CPU DAIs Vinod Koul
2018-04-30 16:22 ` Charles Keepax
2018-04-19 9:49 ` [PATCH v3 2/3] ASoC: Add Multi CPU DAI support for PCM ops Vinod Koul
2018-04-30 16:22 ` Charles Keepax
2018-05-02 9:15 ` Shreyas NC
2018-04-19 9:49 ` [PATCH v3 3/3] ASoC: Add Multi CPU DAI support in DAPM Vinod Koul
2018-04-30 16:24 ` Charles Keepax [this message]
2018-04-19 11:12 ` [PATCH v3 0/3] ASoC: Add Multi CPU DAI support Mark Brown
2018-04-19 14:54 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430162456.34232lvulubgp5ky@localhost.localdomain \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=shreyas.nc@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox