alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	jarkko.nikula@bitmer.com
Cc: tony@atomide.com, alsa-devel@alsa-project.org, aaro.koskinen@iki.fi
Subject: [PATCH v2 0/2] ASoC: omap: sdma-pcm: modpost warning fix and include cleanup
Date: Tue, 15 May 2018 09:43:33 +0300	[thread overview]
Message-ID: <20180515064335.20565-1-peter.ujfalusi@ti.com> (raw)

Hi,

Changes since v1:
- Changed the MODULE_LICENSE from "GPL" to "GPL v2" to match the SPDX line.

Since the sdma-pcm can be built as module it must have MODULE_LICENSE defined,
whcih I have missed:

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
see include/linux/module.h for more information

The first patch also going to fix runtime issue with module loading:
snd_soc_sdma: Unknown symbol devm_kmalloc (err 0)
snd_soc_sdma: Unknown symbol omap_dma_filter_fn (err 0)
snd_soc_sdma: Unknown symbol snd_dmaengine_pcm_prepare_slave_config (err 0)
snd_soc_sdma: Unknown symbol devm_snd_dmaengine_pcm_register (err 0)

As these symbols are EXPORT_SYMBOL_GPL()...

Introduced by commit

  dde637f2daf1 ("ASoC: omap: Introduce the generic_dmaengine_pcm based sdma-pcm")

The second patch is kust a small adjustement for the include files.

Regards,
Peter
---
Peter Ujfalusi (2):
  ASoC: omap: sdma-pcm: Fix modpost warning
  ASoC: omap: sdma-pcm: Correction for the include files

 sound/soc/omap/sdma-pcm.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

             reply	other threads:[~2018-05-15  6:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15  6:43 Peter Ujfalusi [this message]
2018-05-15  6:43 ` [PATCH v2 1/2] ASoC: omap: sdma-pcm: Fix modpost warning Peter Ujfalusi
2018-05-17 16:40   ` Applied "ASoC: omap: sdma-pcm: Fix modpost warning" to the asoc tree Mark Brown
2018-05-15  6:43 ` [PATCH v2 2/2] ASoC: omap: sdma-pcm: Correction for the include files Peter Ujfalusi
  -- strict thread matches above, loose matches on Subject: below --
2018-05-15  6:42 [PATCH v2 0/2] ASoC: omap: sdma-pcm: modpost warning fix and include cleanup Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180515064335.20565-1-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=lgirdwood@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).