From: Vinod <vkoul@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: tiwai@suse.de, liam.r.girdwood@linux.intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org,
Keyon Jie <yang.jie@linux.intel.com>
Subject: Re: [PATCH] ASoC: pcm512x: Add ACPI support
Date: Fri, 18 May 2018 10:06:39 +0530 [thread overview]
Message-ID: <20180518043639.GF2932@vkoul-mobl> (raw)
In-Reply-To: <20180517225326.30881-1-pierre-louis.bossart@linux.intel.com>
On 17-05-18, 17:53, Pierre-Louis Bossart wrote:
> HID is assumed to be made of TI PCI ID (0x104C) + part number, so all
> four 104C5121, 104C5122, 104C5141 104C5142 are valid.
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
...
> static struct i2c_driver pcm512x_i2c_driver = {
> .probe = pcm512x_i2c_probe,
> @@ -67,7 +81,8 @@ static struct i2c_driver pcm512x_i2c_driver = {
> .id_table = pcm512x_i2c_id,
> .driver = {
> .name = "pcm512x",
> - .of_match_table = pcm512x_of_match,
> + .of_match_table = of_match_ptr(pcm512x_of_match),
this change may not be part of this and should be mentioned in the log
Also quick grep tells me kernel has both :(
> + .acpi_match_table = ACPI_PTR(pcm512x_acpi_match),
> .pm = &pcm512x_pm_ops,
> },
> };
> --
> 2.14.1
--
~Vinod
next prev parent reply other threads:[~2018-05-18 4:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 22:53 [PATCH] ASoC: pcm512x: Add ACPI support Pierre-Louis Bossart
2018-05-18 4:36 ` Vinod [this message]
2018-05-18 16:07 ` Pierre-Louis Bossart
2018-05-18 16:16 ` Takashi Iwai
2018-05-18 16:46 ` Applied "ASoC: pcm512x: Add ACPI support" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518043639.GF2932@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox