* [PATCH] Fixed typo on ac97_fc_rec_volume_put.
@ 2018-05-24 16:05 Guy Chronister
2018-05-28 15:28 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Guy Chronister @ 2018-05-24 16:05 UTC (permalink / raw)
To: alsa-devel; +Cc: Guy Chronister
Signed-off-by: Guy Chronister <guylovesbritt@gmail.com>
---
sound/pci/oxygen/oxygen_mixer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c
index 4ca12665ff73..64a82688d7fb 100644
--- a/sound/pci/oxygen/oxygen_mixer.c
+++ b/sound/pci/oxygen/oxygen_mixer.c
@@ -730,7 +730,7 @@ static int ac97_fp_rec_volume_put(struct snd_kcontrol *ctl,
oldreg = oxygen_read_ac97(chip, 1, AC97_REC_GAIN);
newreg = oldreg & ~0x0707;
newreg = newreg | (value->value.integer.value[0] & 7);
- newreg = newreg | ((value->value.integer.value[0] & 7) << 8);
+ newreg = newreg | ((value->value.integer.value[1] & 7) << 8);
change = newreg != oldreg;
if (change)
oxygen_write_ac97(chip, 1, AC97_REC_GAIN, newreg);
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fixed typo on ac97_fc_rec_volume_put.
2018-05-24 16:05 [PATCH] Fixed typo on ac97_fc_rec_volume_put Guy Chronister
@ 2018-05-28 15:28 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2018-05-28 15:28 UTC (permalink / raw)
To: Guy Chronister; +Cc: alsa-devel
On Thu, 24 May 2018 18:05:37 +0200,
Guy Chronister wrote:
>
> Signed-off-by: Guy Chronister <guylovesbritt@gmail.com>
Actually this is not about fixing typo, but fixing a real bug that
ignores the right channel for the recording volume.
Could you refresh the change log text to referring that?
thanks,
Takashi
> ---
> sound/pci/oxygen/oxygen_mixer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c
> index 4ca12665ff73..64a82688d7fb 100644
> --- a/sound/pci/oxygen/oxygen_mixer.c
> +++ b/sound/pci/oxygen/oxygen_mixer.c
> @@ -730,7 +730,7 @@ static int ac97_fp_rec_volume_put(struct snd_kcontrol *ctl,
> oldreg = oxygen_read_ac97(chip, 1, AC97_REC_GAIN);
> newreg = oldreg & ~0x0707;
> newreg = newreg | (value->value.integer.value[0] & 7);
> - newreg = newreg | ((value->value.integer.value[0] & 7) << 8);
> + newreg = newreg | ((value->value.integer.value[1] & 7) << 8);
> change = newreg != oldreg;
> if (change)
> oxygen_write_ac97(chip, 1, AC97_REC_GAIN, newreg);
> --
> 2.17.0
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-28 15:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-24 16:05 [PATCH] Fixed typo on ac97_fc_rec_volume_put Guy Chronister
2018-05-28 15:28 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).