Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@zonque.org>
To: lgirdwood@gmail.com, broonie@kernel.org,
	kuninori.morimoto.gx@renesas.com
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	Daniel Mack <daniel@zonque.org>
Subject: [PATCH 1/3] ASoC: simple-card: set cpu dai clk in hw_params
Date: Mon, 28 May 2018 21:35:01 +0200	[thread overview]
Message-ID: <20180528193503.18905-2-daniel@zonque.org> (raw)
In-Reply-To: <20180528193503.18905-1-daniel@zonque.org>

The simple-card driver currently accepts a clock node in the cpu dai
sub-node and only uses it as an alternative to the
'system-clock-frequency' property to get the current frequency.

This patch adds another use of the passed clock node. If mclk-fs is
specified, the clock will be set to the calculated rate (stream rate *
mclk_fs) in hw_params. This allows platforms to pass a tuneable clock
as phandle that will automatically be set to the right rates.

Signed-off-by: Daniel Mack <daniel@zonque.org>
---
 Documentation/devicetree/bindings/sound/simple-card.txt | 5 +++++
 sound/soc/generic/simple-card.c                         | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/simple-card.txt b/Documentation/devicetree/bindings/sound/simple-card.txt
index 17c13e74667d..a4c72d09cd45 100644
--- a/Documentation/devicetree/bindings/sound/simple-card.txt
+++ b/Documentation/devicetree/bindings/sound/simple-card.txt
@@ -86,6 +86,11 @@ Optional CPU/CODEC subnodes properties:
 					  in dai startup() and disabled with
 					  clk_disable_unprepare() in dai
 					  shutdown().
+					  If a clock is specified and a
+					  multiplication factor is given with
+					  mclk-fs, the clock will be set to the
+					  calculated mclk frequency when the
+					  stream starts.
 - system-clock-direction-out		: specifies clock direction as 'out' on
 					  initialization. It is useful for some aCPUs with
 					  fixed clocks.
diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
index 6959a74a6f49..ca529a6cab06 100644
--- a/sound/soc/generic/simple-card.c
+++ b/sound/soc/generic/simple-card.c
@@ -154,6 +154,10 @@ static int asoc_simple_card_hw_params(struct snd_pcm_substream *substream,
 
 	if (mclk_fs) {
 		mclk = params_rate(params) * mclk_fs;
+
+		if (dai_props->cpu_dai.clk)
+			clk_set_rate(dai_props->cpu_dai.clk, mclk);
+
 		ret = snd_soc_dai_set_sysclk(codec_dai, 0, mclk,
 					     SND_SOC_CLOCK_IN);
 		if (ret && ret != -ENOTSUPP)
-- 
2.14.3

  reply	other threads:[~2018-05-28 19:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-28 19:35 [PATCH 0/3] ASoC: make simple-card a bit more versatile Daniel Mack
2018-05-28 19:35 ` Daniel Mack [this message]
2018-05-29  1:38   ` [PATCH 1/3] ASoC: simple-card: set cpu dai clk in hw_params Kuninori Morimoto
2018-05-29  4:26     ` Daniel Mack
2018-05-29 11:16   ` Mark Brown
2018-05-29 11:17     ` Daniel Mack
2018-05-29 11:32       ` Mark Brown
2018-05-29 20:31         ` Daniel Mack
2018-05-28 19:35 ` [PATCH 2/3] ASoC: simple-card: make sysclk index configurable Daniel Mack
2018-05-29  1:35   ` Kuninori Morimoto
2018-05-29  4:34     ` Daniel Mack
2018-05-29 11:24   ` Mark Brown
2018-05-29 20:23     ` Daniel Mack
2018-05-30  9:49       ` Mark Brown
2018-05-31 17:02       ` Rob Herring
2018-05-31 20:03         ` Daniel Mack
2018-06-01 14:21           ` Rob Herring
2018-05-28 19:35 ` [PATCH 3/3] ASoC: simple-card: add support for clock divider setup Daniel Mack
2018-05-29  1:31   ` Kuninori Morimoto
2018-05-29 11:35   ` Mark Brown
2018-05-29 20:29     ` Daniel Mack
2018-05-30  9:10       ` Mark Brown
2018-05-30  9:12         ` Daniel Mack
2018-06-23 18:41           ` Daniel Mack
2018-06-25 11:24             ` Mark Brown
2018-06-25 12:55               ` Daniel Mack
2018-06-25 12:57                 ` Mark Brown
2018-06-25 12:57                   ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180528193503.18905-2-daniel@zonque.org \
    --to=daniel@zonque.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox