From: Naveen M <naveen.m@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Harsha Priya <harshapriya.n@intel.com>,
alsa-devel@alsa-project.org, broonie@kernel.org,
pierre-louis.bossart@intel.com
Subject: Re: [PATCH] ASoC: Intel: Boards: Add GLK Realtek Maxim I2S machine driver
Date: Mon, 18 Jun 2018 21:57:40 +0530 [thread overview]
Message-ID: <20180618162731.GA9141@intel.com> (raw)
In-Reply-To: <3593ad31-ca5d-432b-5d68-2c7b2ba42914@linux.intel.com>
On Mon, Jun 18, 2018 at 11:08:22AM -0500, Pierre-Louis Bossart wrote:
>
>
> On 06/18/2018 10:46 AM, Naveen Manohar wrote:
> >Patch adds Geminilake I2S machine driver which uses following codecs:
> >RT5682 and MAX98357A.
> Thanks Naveen. Looks good to me, just 4 nit-picks below on style (reverse
> x-mas tree order for variable definitions)
> if you can fix, add my tag below and resubmit it'd nice.
>
> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
Sure, I will do that. Thanks for pointing this out and this Ack.
> >+static int platform_clock_control(struct snd_soc_dapm_widget *w,
> >+ struct snd_kcontrol *k, int event)
> >+{
> >+ int ret = 0;
> >+ struct snd_soc_dapm_context *dapm = w->dapm;
> >+ struct snd_soc_card *card = dapm->card;
> >+ struct snd_soc_dai *codec_dai;
> here..
> >+static int geminilake_rt5682_codec_init(struct snd_soc_pcm_runtime *rtd)
> >+{
> >+ int ret;
> >+ struct snd_soc_jack *jack;
> >+ struct snd_soc_dai *codec_dai = rtd->codec_dai;
> >+ struct snd_soc_component *component = rtd->codec_dai->component;
> >+ struct glk_card_private *ctx = snd_soc_card_get_drvdata(rtd->card);
> and here
> >+static int geminilake_rt5682_fe_init(struct snd_soc_pcm_runtime *rtd)
> >+{
> >+ int ret;
> >+ struct snd_soc_dapm_context *dapm;
> >+ struct snd_soc_component *component = rtd->cpu_dai->component;
> and here
> >+static int glk_card_late_probe(struct snd_soc_card *card)
> >+{
> >+ struct glk_card_private *ctx = snd_soc_card_get_drvdata(card);
> >+ struct snd_soc_component *component = NULL;
> >+ char jack_name[NAME_SIZE];
> >+ struct glk_hdmi_pcm *pcm;
> >+ int err, i = 0;
> one last, i find it more readable to have one assignment per line.
>
Sure.
--
prev parent reply other threads:[~2018-06-18 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 15:46 [PATCH] ASoC: Intel: Boards: Add GLK Realtek Maxim I2S machine driver Naveen Manohar
2018-06-18 16:08 ` Pierre-Louis Bossart
2018-06-18 16:27 ` Naveen M [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618162731.GA9141@intel.com \
--to=naveen.m@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=harshapriya.n@intel.com \
--cc=pierre-louis.bossart@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).