From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, liam.r.girdwood@linux.intel.com, vkoul@kernel.org,
broonie@kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 2/8] ASoC: Intel: Skylake: cleanup before moving ACPI tables
Date: Mon, 18 Jun 2018 13:29:36 -0500 [thread overview]
Message-ID: <20180618182942.4925-3-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20180618182942.4925-1-pierre-louis.bossart@linux.intel.com>
There is no need to deal with DMICs if the DSP is not present and
there is no ACPI machine ID found.
Simplify before moving these ACPI tables to sound/soc/intel/common
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/intel/skylake/skl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
index 0a8f0768e987..6dec748e8949 100644
--- a/sound/soc/intel/skylake/skl.c
+++ b/sound/soc/intel/skylake/skl.c
@@ -500,10 +500,12 @@ static int skl_find_machine(struct skl *skl, void *driver_data)
skl->mach = mach;
skl->fw_name = mach->fw_filename;
- pdata = skl->mach->pdata;
+ pdata = mach->pdata;
- if (mach->pdata)
+ if (pdata) {
skl->use_tplg_pcm = pdata->use_tplg_pcm;
+ pdata->dmic_num = skl_get_dmic_geo(skl);
+ }
return 0;
}
@@ -930,8 +932,6 @@ static int skl_probe(struct pci_dev *pci,
pci_set_drvdata(skl->pci, ebus);
- skl_dmic_data.dmic_num = skl_get_dmic_geo(skl);
-
/* check if dsp is there */
if (bus->ppcap) {
/* create device for dsp clk */
--
2.14.1
next prev parent reply other threads:[~2018-06-18 18:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 18:29 [PATCH 0/8] ASoC: Intel: common ACPI tables - take2 Pierre-Louis Bossart
2018-06-18 18:29 ` [PATCH 1/8] ASoC: Intel: broxton: reduce machine name for bxt_da7219_max98357a Pierre-Louis Bossart
2018-06-18 18:29 ` Pierre-Louis Bossart [this message]
2018-06-19 15:24 ` Applied "ASoC: Intel: Skylake: cleanup before moving ACPI tables" to the asoc tree Mark Brown
2018-06-18 18:29 ` [PATCH 3/8] ASoC: Intel: move SKL+ codec ACPI tables to common directory Pierre-Louis Bossart
2018-06-19 15:24 ` Applied "ASoC: Intel: move SKL+ codec ACPI tables to common directory" to the asoc tree Mark Brown
2018-06-18 18:29 ` [PATCH 4/8] ASoC: Intel: common: Add Geminilake Dialog+Maxim machine driver entry Pierre-Louis Bossart
2018-06-19 15:24 ` Applied "ASoC: Intel: common: Add Geminilake Dialog+Maxim machine driver entry" to the asoc tree Mark Brown
2018-06-18 18:29 ` [PATCH 5/8] ASoC: Intel: common: add firmware/topology information for SOF Pierre-Louis Bossart
2018-06-19 15:24 ` Applied "ASoC: Intel: common: add firmware/topology information for SOF" to the asoc tree Mark Brown
2018-06-18 18:29 ` [PATCH 6/8] ASoC: Intel: common: add Geminilake Realtek+Maxim machine driver entry Pierre-Louis Bossart
2018-06-18 18:29 ` [PATCH 7/8] ASoC: Intel: common: add entries for SOF-based machine drivers Pierre-Louis Bossart
2018-06-19 15:24 ` Applied "ASoC: Intel: common: add entries for SOF-based machine drivers" to the asoc tree Mark Brown
2018-06-18 18:29 ` [PATCH 8/8] ASoC: Intel: common: fix copy/paste issue with SOF/broadwell topology file Pierre-Louis Bossart
2018-06-19 15:24 ` Applied "ASoC: Intel: common: fix copy/paste issue with SOF/broadwell topology file" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618182942.4925-3-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).