Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Mark Brown <broonie@kernel.org>, Bard Liao <bardliao@realtek.com>,
	Oder Chiou <oder_chiou@realtek.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	alsa-devel@alsa-project.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Carlo Caione <carlo@endlessm.com>
Subject: [PATCH 7/9] ASoC: Intel: bytcr_rt5651: Simplify card long-name
Date: Sun, 24 Jun 2018 16:06:32 +0200	[thread overview]
Message-ID: <20180624140634.16835-8-hdegoede@redhat.com> (raw)
In-Reply-To: <20180624140634.16835-1-hdegoede@redhat.com>

Now that the headset-mic is always IN3 there is no reason to have
the headset-mic mapping in the long-name.

This commit simplifies the long name to "bytcr-rt5651-<intmic-map>-mic".

We can safely do this without causing regressions (UCM profile not found
due to the longname change) as the UCM profiles are not in upstream
alsa-lib yet.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/soc/intel/boards/bytcr_rt5651.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards/bytcr_rt5651.c
index 4499960e1c21..45a11799c008 100644
--- a/sound/soc/intel/boards/bytcr_rt5651.c
+++ b/sound/soc/intel/boards/bytcr_rt5651.c
@@ -683,7 +683,7 @@ static struct snd_soc_card byt_rt5651_card = {
 static char byt_rt5651_codec_name[SND_ACPI_I2C_ID_LEN];
 static char byt_rt5651_codec_aif_name[12]; /*  = "rt5651-aif[1|2]" */
 static char byt_rt5651_cpu_dai_name[10]; /*  = "ssp[0|2]-port" */
-static char byt_rt5651_long_name[40]; /* = "bytcr-rt5651-*-spk-*-mic" */
+static char byt_rt5651_long_name[40]; /* = "bytcr-rt5651-*-mic" */
 
 static bool is_valleyview(void)
 {
@@ -704,8 +704,7 @@ struct acpi_chan_package {   /* ACPICA seems to require 64 bit integers */
 
 static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
 {
-	const char * const intmic_name[] = { "dmic", "in1", "in12" };
-	const char * const hsmic_name[] = { "in3", "in3", "in3" };
+	const char * const mic_name[] = { "dmic", "in1", "in12" };
 	struct byt_rt5651_private *priv;
 	struct snd_soc_acpi_mach *mach;
 	const char *i2c_name = NULL;
@@ -852,9 +851,8 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
 	}
 
 	snprintf(byt_rt5651_long_name, sizeof(byt_rt5651_long_name),
-		 "bytcr-rt5651-%s-intmic-%s-hsmic",
-		 intmic_name[BYT_RT5651_MAP(byt_rt5651_quirk)],
-		 hsmic_name[BYT_RT5651_MAP(byt_rt5651_quirk)]);
+		 "bytcr-rt5651-%s-mic",
+		 mic_name[BYT_RT5651_MAP(byt_rt5651_quirk)]);
 	byt_rt5651_card.long_name = byt_rt5651_long_name;
 
 	ret_val = devm_snd_soc_register_card(&pdev->dev, &byt_rt5651_card);
-- 
2.17.1

  parent reply	other threads:[~2018-06-24 14:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-24 14:06 [[PATCH 0/9] ASoC: Intel: bytcr_rt5651: Cleanup (input mapping quirks) Hans de Goede
2018-06-24 14:06 ` [PATCH 1/9] ASoC: Intel: bytcr_rt5651: Add BYT_RT5651_DEFAULT_QUIRKS define Hans de Goede
2018-06-27 11:32   ` Applied "ASoC: Intel: bytcr_rt5651: Add BYT_RT5651_DEFAULT_QUIRKS define" to the asoc tree Mark Brown
2018-06-24 14:06 ` [PATCH 2/9] ASoC: Intel: bytcr_rt5651: Change default input map from in2 to in1 Hans de Goede
2018-06-27 11:32   ` Applied "ASoC: Intel: bytcr_rt5651: Change default input map from in2 to in1" to the asoc tree Mark Brown
2018-06-24 14:06 ` [PATCH 3/9] ASoC: Intel: bytcr_rt5651: Fix IN1_IN2_MAP quirk not being logged Hans de Goede
2018-06-27 11:32   ` Applied "ASoC: Intel: bytcr_rt5651: Fix IN1_IN2_MAP quirk not being logged" to the asoc tree Mark Brown
2018-06-24 14:06 ` [PATCH 4/9] ASoC: Intel: bytcr_rt5651: Remove IN2 input mappings Hans de Goede
2018-06-27 11:31   ` Applied "ASoC: Intel: bytcr_rt5651: Remove IN2 input mappings" to the asoc tree Mark Brown
2018-06-24 14:06 ` [PATCH 5/9] ASoC: Intel: bytcr_rt5651: Fix IN1 map headsetmic mapping Hans de Goede
2018-06-27 11:31   ` Applied "ASoC: Intel: bytcr_rt5651: Fix IN1 map headsetmic mapping" to the asoc tree Mark Brown
2018-06-24 14:06 ` [PATCH 6/9] ASoC: Intel: bytcr_rt5651: Fix DMIC map headsetmic mapping Hans de Goede
2018-06-27 11:31   ` Applied "ASoC: Intel: bytcr_rt5651: Fix DMIC map headsetmic mapping" to the asoc tree Mark Brown
2018-06-24 14:06 ` Hans de Goede [this message]
2018-06-27 11:31   ` Applied "ASoC: Intel: bytcr_rt5651: Simplify card long-name" " Mark Brown
2018-06-24 14:06 ` [PATCH 8/9] ASoC: Intel: bytcr_rt5651: Add BYT_RT5651_HP_LR_SWAPPED quirk Hans de Goede
2018-06-27 11:30   ` Applied "ASoC: Intel: bytcr_rt5651: Add BYT_RT5651_HP_LR_SWAPPED quirk" to the asoc tree Mark Brown
2018-06-24 14:06 ` [PATCH 9/9] ASoC: Intel: bytcr_rt5651: Sort DMI table entries alphabetically Hans de Goede
2018-06-27 11:30   ` Applied "ASoC: Intel: bytcr_rt5651: Sort DMI table entries alphabetically" to the asoc tree Mark Brown
2018-06-25 20:01 ` [[PATCH 0/9] ASoC: Intel: bytcr_rt5651: Cleanup (input mapping quirks) Pierre-Louis Bossart
2018-06-26  9:47   ` Hans de Goede
2018-06-27  4:40     ` Pierre-Louis Bossart
2018-06-27  7:16       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180624140634.16835-8-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bardliao@realtek.com \
    --cc=broonie@kernel.org \
    --cc=carlo@endlessm.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=oder_chiou@realtek.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox