From: Sanyog Kale <sanyog.r.kale@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: patches.audio@intel.com, gregkh@linuxfoundation.org,
alsa-devel@alsa-project.org, vkoul@kernel.org,
Shreyas NC <shreyas.nc@intel.com>
Subject: Re: [PATCH v5 8/9] soundwire: Add support for multi link bank switch
Date: Tue, 10 Jul 2018 22:07:55 +0530 [thread overview]
Message-ID: <20180710163754.GA22349@buildpc-HP-Z230> (raw)
In-Reply-To: <6ac86676-ad92-141d-bda7-99549e0d76ea@linux.intel.com>
On Mon, Jul 09, 2018 at 06:22:26PM -0500, Pierre-Louis Bossart wrote:
>
> >@@ -1170,6 +1276,17 @@ int sdw_stream_add_master(struct sdw_bus *bus,
> > stream->m_rt_count++;
> >+ /*
> >+ * For multi link streams, add the second master only if
> >+ * the bus supports it.
> >+ * Check if bus->multi_link is set
> >+ */
> >+ if (!bus->multi_link && stream->m_rt_count > 1) {
> >+ dev_err(bus->dev,
> >+ "Multilink not supported, link %d", bus->link_id);
> >+ goto stream_error;
> >+ }
> >+
> > goto unlock;
> > stream_error:
> >
>
> This error handling is a bit weird. It's make more sense to check upfront if
> there is already one m_rt allocated (m_rt_count > 0) and bail to avoid
> allocating/releasing a stream. Also there should be a return value set
> (-EINVAL?)
Agreed, this error check should be done upfront. Will fix this and
also the return value.
--
next prev parent reply other threads:[~2018-07-10 16:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 11:46 [PATCH v5 0/9] soundwire: Add multi link support Shreyas NC
2018-07-05 11:46 ` [PATCH v5 1/9] soundwire: Fix duplicate stream state assignment Shreyas NC
2018-07-09 23:41 ` Pierre-Louis Bossart
2018-07-10 17:03 ` Sanyog Kale
2018-07-05 11:46 ` [PATCH v5 2/9] soundwire: fix incorrect exit after configuring stream Shreyas NC
2018-07-05 11:46 ` [PATCH v5 3/9] Documentation: soundwire: Add documentation for multi link Shreyas NC
2018-07-05 11:46 ` [PATCH v5 4/9] soundwire: Initialize completion for defer messages Shreyas NC
2018-07-05 11:46 ` [PATCH v5 5/9] soundwire: Add support to lock across bus instances Shreyas NC
2018-07-05 11:46 ` [PATCH v5 6/9] soundwire: Handle multiple master instances in a stream Shreyas NC
2018-07-09 23:42 ` Pierre-Louis Bossart
2018-07-10 17:02 ` Sanyog Kale
2018-07-10 18:16 ` Pierre-Louis Bossart
2018-07-11 3:47 ` Sanyog Kale
2018-07-05 11:46 ` [PATCH v5 7/9] soundwire: keep track of Masters " Shreyas NC
2018-07-05 11:46 ` [PATCH v5 8/9] soundwire: Add support for multi link bank switch Shreyas NC
2018-07-09 23:22 ` Pierre-Louis Bossart
2018-07-10 16:37 ` Sanyog Kale [this message]
2018-07-05 11:46 ` [PATCH v5 9/9] soundwire: intel: Add pre/post bank switch ops Shreyas NC
2018-07-09 23:47 ` [PATCH v5 0/9] soundwire: Add multi link support Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710163754.GA22349@buildpc-HP-Z230 \
--to=sanyog.r.kale@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=patches.audio@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shreyas.nc@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox