alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
To: Jim Qu <Jim.Qu-5C7GfCeVMHo@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 1/2] ALSA: HDA: use PCI_BASE_CLASS_DISPLAY to cover more display adapters
Date: Fri, 13 Jul 2018 10:31:05 +0200	[thread overview]
Message-ID: <20180713083105.GA4265@wunner.de> (raw)
In-Reply-To: <1531469162-6472-1-git-send-email-Jim.Qu-5C7GfCeVMHo@public.gmane.org>

On Fri, Jul 13, 2018 at 04:06:01PM +0800, Jim Qu wrote:
> Signed-off-by: Jim Qu <Jim.Qu@amd.com>

Empty commit message.  Please add an explanation why the change is
necessary so folks browsing the git history understand it's motivation.
I think here the motivation is that the PCI class is sometimes
PCI_CLASS_DISPLAY_3D or PCI_CLASS_DISPLAY_OTHER.


> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -31,7 +31,7 @@
>   *  CHANGES:
>   *
>   *  2004.12.01	Major rewrite by tiwai, merged the work of pshou
> - * 
> + *

Spurious unrelated change, please get rid of it, this clutters up
the git history unnecessarily.


> @@ -390,8 +390,8 @@ static char *driver_short_names[] = {
>  	[AZX_DRIVER_SIS] = "HDA SIS966",
>  	[AZX_DRIVER_ULI] = "HDA ULI M5461",
>  	[AZX_DRIVER_NVIDIA] = "HDA NVidia",
> -	[AZX_DRIVER_TERA] = "HDA Teradici", 
> -	[AZX_DRIVER_CTX] = "HDA Creative", 
> +	[AZX_DRIVER_TERA] = "HDA Teradici",
> +	[AZX_DRIVER_CTX] = "HDA Creative",

Ditto.

Thanks,

Lukas
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2018-07-13  8:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13  8:06 [PATCH 1/2] ALSA: HDA: use PCI_BASE_CLASS_DISPLAY to cover more display adapters Jim Qu
2018-07-13  8:06 ` [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function Jim Qu
     [not found]   ` <1531469162-6472-2-git-send-email-Jim.Qu-5C7GfCeVMHo@public.gmane.org>
2018-07-13  8:46     ` [alsa-devel] " Takashi Iwai
     [not found]       ` <s5hmuuv8qvp.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-07-13 15:25         ` jimqu
2018-07-13 16:38           ` Takashi Iwai
     [not found]             ` <s5hbmbbm6q9.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-07-13 16:51               ` [alsa-devel] " jimqu
2018-07-13  9:27     ` Lukas Wunner
     [not found]       ` <20180713092742.GA4013-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2018-07-13 15:34         ` jimqu
2018-07-14  6:15         ` jimqu
2018-07-16 14:02           ` Lukas Wunner
     [not found]             ` <20180716140246.GA12334-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2018-07-16 14:45               ` jimqu
     [not found] ` <1531469162-6472-1-git-send-email-Jim.Qu-5C7GfCeVMHo@public.gmane.org>
2018-07-13  8:31   ` Lukas Wunner [this message]
2018-07-13  8:33   ` [alsa-devel] [PATCH 1/2] ALSA: HDA: use PCI_BASE_CLASS_DISPLAY to cover more display adapters Takashi Iwai
     [not found]     ` <s5ho9fb8rh9.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2018-07-13  9:28       ` Qu, Jim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180713083105.GA4265@wunner.de \
    --to=lukas-jfq808j9c/izqb+pc5nmwq@public.gmane.org \
    --cc=Jim.Qu-5C7GfCeVMHo@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).