From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: broonie@kernel.org
Cc: stuarth@opensource.cirrus.com, patches@opensource.cirrus.com,
rf@opensource.cirrus.com, lgirdwood@gmail.com,
alsa-devel@alsa-project.org
Subject: [PATCH 2/5] ASoC: wm_adsp: Take prefix into account in control name length
Date: Thu, 19 Jul 2018 11:50:36 +0100 [thread overview]
Message-ID: <20180719105039.28312-2-ckeepax@opensource.cirrus.com> (raw)
In-Reply-To: <20180719105039.28312-1-ckeepax@opensource.cirrus.com>
Currently when creating ALSA control names for the DSP the length of any
prefix applied to the CODEC is not taken into account. Whilst this is
mostly harmless it does result in ALSA doing the truncation of the
control names and printing a warning. It is better to have the driver do
the truncation so it can truncate from the start of parameter name
itself to give a greater chance of the result maintain a unique name.
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
sound/soc/codecs/wm_adsp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
index 99108d18de8d..eec73c98a141 100644
--- a/sound/soc/codecs/wm_adsp.c
+++ b/sound/soc/codecs/wm_adsp.c
@@ -1343,6 +1343,9 @@ static int wm_adsp_create_control(struct wm_adsp *dsp,
int avail = SNDRV_CTL_ELEM_ID_NAME_MAXLEN - ret - 2;
int skip = 0;
+ if (dsp->component->name_prefix)
+ avail -= strlen(dsp->component->name_prefix) + 1;
+
if (subname_len > avail)
skip = subname_len - avail;
--
2.11.0
next prev parent reply other threads:[~2018-07-19 10:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 10:50 [PATCH 1/5] ASoC: wm_adsp: Correct algorithm list allocation size Charles Keepax
2018-07-19 10:50 ` Charles Keepax [this message]
2018-07-19 16:57 ` Applied "ASoC: wm_adsp: Take prefix into account in control name length" to the asoc tree Mark Brown
2018-07-19 10:50 ` [PATCH 3/5] ASoC: wm_adsp: Ensure DSP boot work complete before preloader_put return Charles Keepax
2018-07-19 16:58 ` Applied "ASoC: wm_adsp: Ensure DSP boot work complete before preloader_put return" to the asoc tree Mark Brown
2018-07-19 10:50 ` [PATCH 4/5] ASoC: wm_adsp: Allow up to 8 channels for voice control Charles Keepax
2018-07-19 16:57 ` Applied "ASoC: wm_adsp: Allow up to 8 channels for voice control" to the asoc tree Mark Brown
2018-07-19 10:50 ` [PATCH 5/5] ASoC: wm_adsp: Parse HOST_BUFFER controls Charles Keepax
2018-07-19 16:57 ` Applied "ASoC: wm_adsp: Parse HOST_BUFFER controls" to the asoc tree Mark Brown
2018-07-19 16:57 ` Applied "ASoC: wm_adsp: Correct algorithm list allocation size" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719105039.28312-2-ckeepax@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=stuarth@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox