From: Vinod <vkoul@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: patches.audio@intel.com, gregkh@linuxfoundation.org,
Sanyog Kale <sanyog.r.kale@intel.com>,
alsa-devel@alsa-project.org, shreyas.nc@intel.com
Subject: Re: [PATCH v6 07/10] soundwire: keep track of Masters in a stream
Date: Fri, 20 Jul 2018 10:13:17 +0530 [thread overview]
Message-ID: <20180720044317.GP3219@vkoul-mobl> (raw)
In-Reply-To: <4a8e46a4-4010-aa70-a3d4-5c5d3faf5245@linux.intel.com>
On 19-07-18, 10:06, Pierre-Louis Bossart wrote:
> On 7/16/18 1:47 PM, Sanyog Kale wrote:
> > From: Shreyas NC <shreyas.nc@intel.com>
> >
> > A multi link bankswitch can be done if the hardware supports and
> > the stream is handled by multiple Master(s).
> >
> > This preparatory patch adds support to track m_rt in a stream.
>
> The order of the patches seems off, you are adding the definition of
> m_rt_count in patch 7 but using it in patch 6, that'll break git bisect.
> What am i missing?
>
> It'd also make more sense to have the reference counts in the same patch,
> it's hard to track otherwise, so maybe one patch to add the definitions and
> inits and the second to increase/decrease+use the value as needed.
Also it would help to have fixes first, so they go in and the bigger
changes later. That is how a series should be built typically.
--
~Vinod
next prev parent reply other threads:[~2018-07-20 4:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 18:47 [PATCH v6 00/10] soundwire: Add multi link support Sanyog Kale
2018-07-16 18:47 ` [PATCH v6 01/10] Documentation: soundwire: Add documentation for multi link Sanyog Kale
2018-07-16 18:47 ` [PATCH v6 02/10] soundwire: Initialize completion for defer messages Sanyog Kale
2018-07-16 18:47 ` [PATCH v6 03/10] soundwire: Fix duplicate stream state assignment Sanyog Kale
2018-07-16 18:47 ` [PATCH v6 04/10] soundwire: fix incorrect exit after configuring stream Sanyog Kale
2018-07-16 18:47 ` [PATCH v6 05/10] soundwire: Add support to lock across bus instances Sanyog Kale
2018-07-16 18:47 ` [PATCH v6 06/10] soundwire: Handle multiple master instances in a stream Sanyog Kale
2018-07-16 18:47 ` [PATCH v6 07/10] soundwire: keep track of Masters " Sanyog Kale
2018-07-19 15:06 ` Pierre-Louis Bossart
2018-07-20 4:43 ` Vinod [this message]
2018-07-23 4:00 ` Sanyog Kale
2018-07-23 3:50 ` Sanyog Kale
2018-07-16 18:47 ` [PATCH v6 08/10] soundwire: Add support for multi link bank switch Sanyog Kale
2018-07-16 18:47 ` [PATCH v6 09/10] soundwire: intel: Add pre/post bank switch ops Sanyog Kale
2018-07-16 18:47 ` [PATCH v6 10/10] soundwire: Fix acquiring bus lock twice during master release Sanyog Kale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720044317.GP3219@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=patches.audio@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=shreyas.nc@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox