From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH] ASoC: wm9712: fix replace codec to component Date: Fri, 20 Jul 2018 14:22:58 +0100 Message-ID: <20180720132258.GD18740@imbe.wolfsonmicro.main> References: <20180720075148.14648-1-marcel@ziswiler.com> <87effy48lz.wl-kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <87effy48lz.wl-kuninori.morimoto.gx@renesas.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Kuninori Morimoto Cc: Kate Stewart , linux-mips@linux-mips.org, alsa-devel@alsa-project.org, Neil Armstrong , Marcel Ziswiler , James Hogan , Takashi Iwai , Thierry Reding , Lee Jones , Robert Jarzmik , Gregory CLEMENT , Russell King , Donglin Peng , Jonathan Hunter , Haojian Zhuang , Boris Brezillon , Mark Brown , linux-tegra@vger.kernel.org, Han Xu , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, Bhumika Goyal , Greg Kroah-Hartman , Liam List-Id: alsa-devel@alsa-project.org On Fri, Jul 20, 2018 at 08:30:41AM +0000, Kuninori Morimoto wrote: > > Hi Marcel > > > From: Marcel Ziswiler > > > > Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component") > > "wm9712-codec" got renamed to "wm9712-component", however, this change > > never got propagated down to the actual board/platform drivers. E.g. on > > Colibri T20 this lead to the following spew upon boot with sound/touch > > being broken: > > Oops, my bad... > The platform_driver name is not important, > how about simply rename back it to "wm9712-codec" ? > Yeah I would agree here wm9712-component isn't great as a name for board files etc. Lets rename back to wm9712-codec for these specific bits. Thanks, Charles