Re: [PATCH v7 09/10] soundwire: Add support for multi link bank switch

[Shreyas Nc <shreyas.nc@intel.com>]

> >+		ret = sdw_transfer_defer(bus, wr_msg, &bus->defer_msg);
> >+	else
> >+		ret = sdw_transfer(bus, wr_msg);
> >+
> >  	if (ret < 0) {
> >  		dev_err(bus->dev, "Slave frame_ctrl reg write failed");
> >  		goto error;
> >  	}
> >-	kfree(wr_msg);
> >-	kfree(wbuf);
> >-	bus->defer_msg.msg = NULL;
> >-	bus->params.curr_bank = !bus->params.curr_bank;
> >-	bus->params.next_bank = !bus->params.next_bank;
> >+	if (!bus->multi_link) {
> >+		kfree(wr_msg);
> >+		kfree(wbuf);
> >+		bus->defer_msg.msg = NULL;
> >+		bus->params.curr_bank = !bus->params.curr_bank;
> >+		bus->params.next_bank = !bus->params.next_bank;
> >+	}
> 
> Should this test be extended to the case where the bus can support
> multi-link but m_rt_count ==1
> should it be
> if (!multi_link)
> ?
>
Sure, makes sense to add the right check.
v8 on its way ..

--Shreyas

--