From: Ladislav Michl <ladis@linux-mips.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, anish kumar <yesanishhere@gmail.com>
Subject: Re: [PATCH v0 3/3] ASoC: max9867: Fix volume controls
Date: Mon, 30 Jul 2018 12:45:03 +0200 [thread overview]
Message-ID: <20180730104503.GA7186@lenoch> (raw)
In-Reply-To: <20180730101115.GD5789@sirena.org.uk>
On Mon, Jul 30, 2018 at 11:11:15AM +0100, Mark Brown wrote:
> On Sat, Jul 28, 2018 at 05:44:15PM +0200, Ladislav Michl wrote:
> > Build proper audio paths and fix volume controls to match datasheet.
>
> This sounds like it should be split up into separate patches for at
> least the routing and volume control stuff. It also needs a bit of a
> better changelog as I'm not sure what the issues with the volume
> controls were or what was improper about the old audio paths.
Oh well, will do. Perhaps driver author wants to step in and describe
setup driver was tested with. This is not meant as an offense, but
it does really look like code was copied over from other drivers
(sometimes without renaming) until it compiled and then submitted.
As it is I'm unable to play or record anything as power domains
are not enabled, but there still is a chance I'm doing something
wrong.
> > Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> > ---
> > I'm still unsure about control names, please see yet unaswered mail
> > here: https://www.spinics.net/lists/alsa-devel/msg80006.html
>
> Always CC maintainers on mails - you really shouldn't rely on anyone
> seeing anything that only goes to the lists, they're quite high volume.
Well, in this case I decided to sent general question to the list in a
hope anyone with enough knowledge could answer that... But point taken,
will Cc maintaniners next time.
next prev parent reply other threads:[~2018-07-30 10:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 15:41 [PATCH v0 0/3] ASoC: max9867: driver update Ladislav Michl
2018-07-28 15:42 ` [PATCH v0 1/3] ASoC: max9867: Take device out of shutdown Ladislav Michl
2018-07-30 9:23 ` Mark Brown
2018-07-28 15:43 ` [PATCH v0 2/3] ASoC: max9867: Calculate LRCLK divider Ladislav Michl
2018-07-28 15:44 ` [PATCH v0 3/3] ASoC: max9867: Fix volume controls Ladislav Michl
2018-07-30 10:11 ` Mark Brown
2018-07-30 10:45 ` Ladislav Michl [this message]
2018-07-30 10:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730104503.GA7186@lenoch \
--to=ladis@linux-mips.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=yesanishhere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).