alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Colin King <colin.king@canonical.com>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Jaya Kumar <jayakumar.alsa@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Olivier Moysan <olivier.moysan@st.com>,
	Arnaud Pouliquen <arnaud.pouliquen@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/9] ALSA: ens137x: remove redundant array pcm_devs
Date: Wed,  1 Aug 2018 11:47:37 +0100	[thread overview]
Message-ID: <20180801104742.4328-5-colin.king@canonical.com> (raw)
In-Reply-To: <20180801104742.4328-1-colin.king@canonical.com>

From: Colin Ian King <colin.king@canonical.com>

The array pcm_devs is being assigned but is never used hence it is
redundant and can be removed.

Cleans up clang warning:
warning: variable 'pcm_devs' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/pci/ens1370.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c
index 39f79a6b5283..727eb3da1fda 100644
--- a/sound/pci/ens1370.c
+++ b/sound/pci/ens1370.c
@@ -2392,7 +2392,7 @@ static int snd_audiopci_probe(struct pci_dev *pci,
 	static int dev;
 	struct snd_card *card;
 	struct ensoniq *ensoniq;
-	int err, pcm_devs[2];
+	int err;
 
 	if (dev >= SNDRV_CARDS)
 		return -ENODEV;
@@ -2412,7 +2412,6 @@ static int snd_audiopci_probe(struct pci_dev *pci,
 	}
 	card->private_data = ensoniq;
 
-	pcm_devs[0] = 0; pcm_devs[1] = 1;
 #ifdef CHIP1370
 	if ((err = snd_ensoniq_1370_mixer(ensoniq)) < 0) {
 		snd_card_free(card);
-- 
2.17.1

  parent reply	other threads:[~2018-08-01 10:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 10:47 [PATCH 0/9] ALSA: remove redundant variables Colin King
2018-08-01 10:47 ` [PATCH 1/9] ALSA: asihpi: remove redundant variable max_streams Colin King
2018-08-01 12:00   ` Takashi Iwai
2018-08-01 10:47 ` [PATCH 2/9] ALSA: cs5535audio: remove redundant pointer 'dma' Colin King
2018-08-01 12:01   ` Takashi Iwai
2018-08-01 10:47 ` [PATCH 3/9] ALSA: emu10k1: remove redundant variable attn Colin King
2018-08-01 12:01   ` Takashi Iwai
2018-08-01 10:47 ` Colin King [this message]
2018-08-01 12:01   ` [PATCH 4/9] ALSA: ens137x: remove redundant array pcm_devs Takashi Iwai
2018-08-01 10:47 ` [PATCH 5/9] ALSA: sonicvibes: remove redundant pointer 'dir' Colin King
2018-08-01 12:01   ` Takashi Iwai
2018-08-01 10:47 ` [PATCH 6/9] ASoC: nau8540: remove redundant variable osrate Colin King
2018-08-01 11:17   ` Applied "ASoC: nau8540: remove redundant variable osrate" to the asoc tree Mark Brown
2018-08-01 10:47 ` [PATCH 7/9] ASoC: stm32: remove redundant pointers 'priv' and 'rtd' Colin King
2018-08-01 11:16   ` Applied "ASoC: stm32: remove redundant pointers 'priv' and 'rtd'" to the asoc tree Mark Brown
2018-08-01 10:47 ` [PATCH 8/9] ALSA: usb-audio: remove redundant pointer 'urb' Colin King
2018-08-01 12:01   ` Takashi Iwai
2018-08-01 10:47 ` [PATCH 9/9] ALSA: intel_hdmi: remove redundant variable cfg_val Colin King
2018-08-01 11:00   ` Takashi Iwai
2018-08-01 14:55     ` [alsa-devel] " Pierre-Louis Bossart
2018-08-06 18:37     ` Pierre-Louis Bossart
2018-08-06 19:37       ` Takashi Iwai
2018-08-06 19:59         ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801104742.4328-5-colin.king@canonical.com \
    --to=colin.king@canonical.com \
    --cc=alexandre.torgue@st.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnaud.pouliquen@st.com \
    --cc=broonie@kernel.org \
    --cc=jayakumar.alsa@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=olivier.moysan@st.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).