alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Matt Flax <flatmax@flatmax.org>
To: Mark Brown <broonie@kernel.org>,
	alsa-devel@alsa-project.org,
	Brian Austin <brian.austin@cirrus.com>,
	Paul Handrigan <Paul.Handrigan@cirrus.com>,
	ckeepax@opensource.cirrus.com
Cc: Matt Flax <flatmax@flatmax.org>
Subject: [PATCH v2 1/3] ASoC: cs4265: SOC_SINGLE register value error fix
Date: Thu, 30 Aug 2018 09:38:00 +1000	[thread overview]
Message-ID: <20180829233802.22032-1-flatmax@flatmax.org> (raw)

The cs4265 driver declares the "MMTLR Data Switch" register setting with
a 0 register value rather then the 0x12 register (CS4265_SPDIF_CTL2).
This incorrect value causes alsamixer to fault with the output :
cannot load mixer controls: Input/output error

This patch corrects the register value. alsamixer now runs.

Signed-off-by: Matt Flax <flatmax@flatmax.org>
---

Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Identical to the original v1 patch, already acked and reviewed.
---
 sound/soc/codecs/cs4265.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c
index 275677de..15b4ae04 100644
--- a/sound/soc/codecs/cs4265.c
+++ b/sound/soc/codecs/cs4265.c
@@ -157,8 +157,7 @@ static const struct snd_kcontrol_new cs4265_snd_controls[] = {
 	SOC_SINGLE("Validity Bit Control Switch", CS4265_SPDIF_CTL2,
 				3, 1, 0),
 	SOC_ENUM("SPDIF Mono/Stereo", spdif_mono_stereo_enum),
-	SOC_SINGLE("MMTLR Data Switch", 0,
-				1, 1, 0),
+	SOC_SINGLE("MMTLR Data Switch", CS4265_SPDIF_CTL2, 0, 1, 0),
 	SOC_ENUM("Mono Channel Select", spdif_mono_select_enum),
 	SND_SOC_BYTES("C Data Buffer", CS4265_C_DATA_BUFF, 24),
 };
-- 
2.17.1

             reply	other threads:[~2018-08-29 23:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 23:38 Matt Flax [this message]
2018-08-29 23:38 ` [PATCH v2 2/3] ASoC: cs4265: Add native 32bit I2S transport Matt Flax
2018-08-30 15:41   ` Mark Brown
2018-08-30 16:43     ` [PATCH v2 2/3] ASoC: cs4265: Add native 32bit I2S transport [UNSCANNED] Charles Keepax
2018-08-29 23:38 ` [PATCH v2 3/3] ASoC: cs4265: Add a SPDIF enable switch Matt Flax
2018-08-30  9:11   ` Charles Keepax
2018-08-31 15:38   ` Applied "ASoC: cs4265: Add a S/PDIF enable switch" to the asoc tree Mark Brown
2018-08-30  9:11 ` [PATCH v2 1/3] ASoC: cs4265: SOC_SINGLE register value error fix Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180829233802.22032-1-flatmax@flatmax.org \
    --to=flatmax@flatmax.org \
    --cc=Paul.Handrigan@cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=brian.austin@cirrus.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).