From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Matt Flax <flatmax@flatmax.org>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
brian.austin@cirrus.com, paul.handrigan@cirrus.com
Subject: Re: [PATCH] ASoC: cs4265: Add a MIC pre. switch
Date: Fri, 7 Sep 2018 11:55:12 +0100 [thread overview]
Message-ID: <20180907105512.GH1653@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <dc95df9e-e256-863a-3e53-ba18a2366143@flatmax.org>
On Fri, Sep 07, 2018 at 08:18:05PM +1000, Matt Flax wrote:
> On 07/09/18 18:26, Charles Keepax wrote:
> >On Fri, Sep 07, 2018 at 01:27:29PM +1000, Matt Flax wrote:
> >Which would really make DAPM a better fit, unless there are valid
> >use-cases for using the mic with the preamp powered down?
>
> Agreed, when you switch to the MIC rather then LINEIN it should be
> turned on.
>
> This is the DAPM_MUX :
> https://github.com/torvalds/linux/blob/master/sound/soc/codecs/cs4265.c#L178
> This is the ENUM_SINGLE :
> https://github.com/torvalds/linux/blob/master/sound/soc/codecs/cs4265.c#L98
>
> What is the best way to do this ?
Apologies not sure I entirely follow, don't you just want to
update the routes such that the existing "Pre-amp MIC" widget
is between the MICL,R and the ADC Mux. Something like:
{ "Pre-amp MIC", NULL, "MICL" },
{ "Pre-amp MIC", NULL, "MICR" },
{ "ADC Mux", "MIC", "Pre-amp MIC" },
Thanks,
Charles
next prev parent reply other threads:[~2018-09-07 10:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 3:27 [PATCH] ASoC: cs4265: Add a MIC pre. switch Matt Flax
2018-09-07 8:26 ` Charles Keepax
2018-09-07 10:18 ` Matt Flax
2018-09-07 10:55 ` Charles Keepax [this message]
2018-09-07 11:06 ` Matt Flax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907105512.GH1653@imbe.wolfsonmicro.main \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=flatmax@flatmax.org \
--cc=paul.handrigan@cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox