Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 5/8] sound: intel/sst: don't pass GFP_DMA32 to	dma_alloc_coherent
Date: Mon, 15 Oct 2018 10:58:58 +0100	[thread overview]
Message-ID: <20181015095858.GA6277@sirena.org.uk> (raw)
In-Reply-To: <s5hefctm0m3.wl-tiwai@suse.de>


[-- Attachment #1.1: Type: text/plain, Size: 778 bytes --]

On Sun, Oct 14, 2018 at 09:46:44AM +0200, Takashi Iwai wrote:
> Takashi Iwai wrote:
> > Christoph Hellwig wrote:

> > > The DMA API does its own zone decisions based on the coherent_dma_mask.

> > > Signed-off-by: Christoph Hellwig <hch@lst.de>

> > Reviewed-by: Takashi Iwai <tiwai@suse.de>

> Mark, let me know whether you'd take this via your tree or may I take
> via mine (with a minor correction of the subject line).

I don't have the patch...  in fact, having found it in list archives I
see there's also a SPI patch I'll have to go hunting for so I guess I'll
apply this one when I find that :(  Christoph, please CC maintainers.

> FWIW, the driver sets the 31bit (!) DMA mask, and that's the likely
> reason of GFP_DMA passed there in the original code.

Likely, yes.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2018-10-15  9:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-13 15:16 remove bogus GFP_DMA32 flags for dma allocations Christoph Hellwig
2018-10-13 15:17 ` [PATCH 1/8] cpufreq: tegra186: don't pass GFP_DMA32 to dma_alloc_coherent Christoph Hellwig
2018-10-15  7:43   ` Rafael J. Wysocki
2018-10-17  7:19     ` Christoph Hellwig
2018-10-17  7:22       ` Rafael J. Wysocki
2018-10-13 15:17 ` [PATCH 2/8] firmware: tegra: " Christoph Hellwig
2018-10-13 15:17 ` [PATCH 3/8] spi: pic32-sqi: " Christoph Hellwig
2018-10-17 11:55   ` Applied "spi: pic32-sqi: don't pass GFP_DMA32 to dma_alloc_coherent" to the spi tree Mark Brown
2018-10-13 15:17 ` [PATCH 4/8] sound: hpios: don't pass GFP_DMA32 to dma_alloc_coherent Christoph Hellwig
2018-10-13 16:18   ` [alsa-devel] " Takashi Iwai
2018-10-13 16:35     ` Christoph Hellwig
2018-10-13 18:10       ` [alsa-devel] " Takashi Iwai
2018-10-13 15:17 ` [PATCH 5/8] sound: intel/sst: " Christoph Hellwig
2018-10-13 16:20   ` [alsa-devel] " Takashi Iwai
2018-10-14  7:46     ` Takashi Iwai
2018-10-15  9:58       ` Mark Brown [this message]
2018-10-17  7:19         ` Christoph Hellwig
2018-10-17  9:55           ` Mark Brown
2018-10-17 11:54   ` Applied "ASoC: intel: don't pass GFP_DMA32 to dma_alloc_coherent" to the asoc tree Mark Brown
2018-10-13 15:17 ` [PATCH 6/8] drm: sti: don't pass GFP_DMA32 to dma_alloc_wc Christoph Hellwig
2018-10-15  9:12   ` Benjamin Gaignard
2018-10-16 12:41     ` Benjamin Gaignard
2018-10-17  7:19       ` Christoph Hellwig
2018-10-18 11:59         ` Benjamin Gaignard
2018-10-13 15:17 ` [PATCH 7/8] media: sti/bdisp: don't pass GFP_DMA32 to dma_alloc_attrs Christoph Hellwig
2018-10-15  9:12   ` Benjamin Gaignard
2018-10-17  7:20     ` Christoph Hellwig
2018-10-18 12:00       ` Benjamin Gaignard
2018-12-05 10:31         ` Mauro Carvalho Chehab
2018-10-13 15:17 ` [PATCH 8/8] fsl-diu-fb: don't pass GFP_DMA32 to dmam_alloc_coherent Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181015095858.GA6277@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=hch@lst.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox