From: Mark Brown <broonie@kernel.org>
To: mac.chiang@intel.com
Cc: alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com
Subject: Re: [PATCH] ASoC: Intel: Boards: Add KBL Dialog Maxim I2S machine driver
Date: Mon, 15 Oct 2018 12:01:09 +0100 [thread overview]
Message-ID: <20181015110109.GA12949@sirena.org.uk> (raw)
In-Reply-To: <1539070547-14240-1-git-send-email-mac.chiang@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 596 bytes --]
On Tue, Oct 09, 2018 at 03:35:47PM +0800, mac.chiang@intel.com wrote:
> @@ -0,0 +1,983 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright(c) 2018 Intel Corporation.
> +
> +/*
> + * Intel Kabylake I2S Machine Driver with MAX98927 & DA7219 Codecs
> + *
> + * Modified from:
> + * Intel Kabylake I2S Machine driver supporting MAX98927 and
> + * RT5663 codecs
> + */
Please don't mix C and C++ comment styles, just make the entire block
C++ style so it looks more consistent. However this looks otherwise
good so I'll go ahead and apply - please send a followup patch fixing
things up.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-10-15 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 7:35 [PATCH] ASoC: Intel: Boards: Add KBL Dialog Maxim I2S machine driver mac.chiang
2018-10-15 11:01 ` Mark Brown [this message]
2018-10-15 11:21 ` Applied "ASoC: Intel: Boards: Add KBL Dialog Maxim I2S machine driver" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015110109.GA12949@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=mac.chiang@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox