public inbox for alsa-devel@alsa-project.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	liam.r.girdwood@linux.intel.com,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Bard Liao <bardliao@realtek.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	Yangtao Li <tiny.windzz@gmail.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: [PATCH 04/21] ASoC: codecs: fix kernel doc descriptions
Date: Fri,  4 Jan 2019 20:02:32 -0600	[thread overview]
Message-ID: <20190105020249.8639-5-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20190105020249.8639-1-pierre-louis.bossart@linux.intel.com>

Missing or spurious parameter descriptions. Fix warnings with W=1

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/codecs/nau8825.c | 1 +
 sound/soc/codecs/rt5514.c  | 1 +
 sound/soc/codecs/rt5677.c  | 8 ++++----
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c
index 7bbcbf5f05c8..47e65cf99879 100644
--- a/sound/soc/codecs/nau8825.c
+++ b/sound/soc/codecs/nau8825.c
@@ -351,6 +351,7 @@ static void nau8825_hpvol_ramp(struct nau8825 *nau8825,
  * Computes log10 of a value; the result is round off to 3 decimal. This func-
  * tion takes reference to dvb-math. The source code locates as the following.
  * Linux/drivers/media/dvb-core/dvb_math.c
+ * @value:  input for log10
  *
  * return log10(value) * 1000
  */
diff --git a/sound/soc/codecs/rt5514.c b/sound/soc/codecs/rt5514.c
index a67de68b6da6..f9ad6e36ab16 100644
--- a/sound/soc/codecs/rt5514.c
+++ b/sound/soc/codecs/rt5514.c
@@ -489,6 +489,7 @@ static const struct snd_kcontrol_new rt5514_sto2_dmic_mux =
 /**
  * rt5514_calc_dmic_clk - Calculate the frequency divider parameter of dmic.
  *
+ * @component: only used for dev_warn
  * @rate: base clock rate.
  *
  * Choose divider parameter that gives the highest possible DMIC frequency in
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 9b7a1833d331..6fc70e441458 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -547,7 +547,7 @@ static bool rt5677_readable_register(struct device *dev, unsigned int reg)
  * @rt5677: Private Data.
  * @addr: Address index.
  * @value: Address data.
- *
+ * @opcode: opcode value
  *
  * Returns 0 for success or negative error code.
  */
@@ -602,7 +602,7 @@ static int rt5677_dsp_mode_i2c_write_addr(struct rt5677_priv *rt5677,
 
 /**
  * rt5677_dsp_mode_i2c_read_addr - Read value from address on DSP mode.
- * rt5677: Private Data.
+ * @rt5677: Private Data.
  * @addr: Address index.
  * @value: Address data.
  *
@@ -651,7 +651,7 @@ static int rt5677_dsp_mode_i2c_read_addr(
 
 /**
  * rt5677_dsp_mode_i2c_write - Write register on DSP mode.
- * rt5677: Private Data.
+ * @rt5677: Private Data.
  * @reg: Register index.
  * @value: Register data.
  *
@@ -667,7 +667,7 @@ static int rt5677_dsp_mode_i2c_write(struct rt5677_priv *rt5677,
 
 /**
  * rt5677_dsp_mode_i2c_read - Read register on DSP mode.
- * @codec: SoC audio codec device.
+ * @rt5677: Private Data
  * @reg: Register index.
  * @value: Register data.
  *
-- 
2.17.1

  parent reply	other threads:[~2019-01-05  2:02 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-05  2:02 [PATCH 00/21] ASoC: codecs: remove warnings with Sparse, Coccinelle and W=1 Pierre-Louis Bossart
2019-01-05  2:02 ` [PATCH 01/21] ASoC: dmic: declare trigger function as static Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: dmic: declare trigger function as static" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 02/21] ASoC: max98090: remove unused constant variables Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: max98090: remove unused constant variables" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 03/21] ASoC: es8316: remove unused constant variables Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: es8316: remove unused constant variables" to the asoc tree Mark Brown
2019-01-05  2:02 ` Pierre-Louis Bossart [this message]
2019-01-07 18:58   ` Applied "ASoC: codecs: fix kernel doc descriptions" " Mark Brown
2019-01-05  2:02 ` [PATCH 05/21] ASoC: rt5645: remove unused mux define Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: rt5645: remove unused mux define" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 06/21] ASoC: rt5670: remove unused mux/mixer define Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: rt5670: remove unused mux/mixer define" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 07/21] ASoC: max98383: fix boolean assignments to true/false Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: max98383: fix boolean assignments to true/false" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 08/21] ASoC: rt298: fix boolean tests Pierre-Louis Bossart
2019-01-07 18:57   ` Applied "ASoC: rt298: fix boolean tests" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 09/21] ASoC: cs4271: fix boolean assignments Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: cs4271: fix boolean assignments" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 10/21] ASoC: rt274: fix boolean tests Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: rt274: fix boolean tests" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 11/21] ASoc: rt286: fix boolean tests Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoc: rt286: fix boolean tests" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 12/21] ASoC: rt5640: fix boolean assignments Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: rt5640: fix boolean assignments" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 13/21] ASoC: max98927: fix boolean assignments Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: max98927: fix boolean assignments" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 14/21] ASoC: rt5651: fix boolean assignments Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: rt5651: fix boolean assignments" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 15/21] ASoC: nau8824: fix boolean assignment Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: nau8824: fix boolean assignment" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 16/21] ASoC: tscs42xx.c: fix boolean test Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: tscs42xx.c: fix boolean test" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 17/21] ASoC: mt6351: remove unneeded variable Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: mt6351: remove unneeded variable" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 18/21] ASoC: da7219: fix endianness issues Pierre-Louis Bossart
2019-01-07 13:27   ` Adam Thomson
2019-01-07 18:58   ` Applied "ASoC: da7219: fix endianness issues" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 19/21] ASoC: da7219: use logical AND Pierre-Louis Bossart
2019-01-07 13:26   ` Adam Thomson
2019-01-07 18:58   ` Applied "ASoC: da7219: use logical AND" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 20/21] ASoC: rt5645: store eq kcontrol byte in __be Pierre-Louis Bossart
2019-01-07 18:58   ` Applied "ASoC: rt5645: store eq kcontrol byte in __be" to the asoc tree Mark Brown
2019-01-05  2:02 ` [PATCH 21/21] ASoC: rl6437a: use __be32 for a __be32 buf Pierre-Louis Bossart
2019-01-07 18:57   ` Applied "ASoC: rl6437a: use __be32 for a __be32 buf" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190105020249.8639-5-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bardliao@realtek.com \
    --cc=broonie@kernel.org \
    --cc=gustavo@embeddedor.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=tiny.windzz@gmail.com \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox