From: Mark Brown <broonie@kernel.org>
To: Yizhuo <yzhai003@ucr.edu>
Cc: csong@cs.ucr.edu, Oder Chiou <oder_chiou@realtek.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
zhiyunq@cs.ucr.edu, Liam Girdwood <lgirdwood@gmail.com>,
Bard Liao <bardliao@realtek.com>
Subject: Re: [PATCH] ASoC: rt274: Variable "buf" in function rt274_jack_detect() could be uninitialized
Date: Mon, 7 Jan 2019 16:58:34 +0000 [thread overview]
Message-ID: <20190107165834.GL9570@sirena.org.uk> (raw)
In-Reply-To: <20190104202708.14759-1-yzhai003@ucr.edu>
[-- Attachment #1.1: Type: text/plain, Size: 411 bytes --]
On Fri, Jan 04, 2019 at 12:27:08PM -0800, Yizhuo wrote:
> In function rt274_jack_detect(), local variable "buf" could
> be uninitialized if function regmap_read() returns -EINVAL.
> However, it will be used to calculate "hp" and "mic" and
> make their value unpredictable while those value are used
> in the caller. This is potentially unsafe.
This doesn't apply against current code, please check and resend.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2019-01-07 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 20:27 [PATCH] ASoC: rt274: Variable "buf" in function rt274_jack_detect() could be uninitialized Yizhuo
2019-01-07 16:58 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-07 20:12 Yizhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107165834.GL9570@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=csong@cs.ucr.edu \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=tiwai@suse.com \
--cc=yzhai003@ucr.edu \
--cc=zhiyunq@cs.ucr.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox