Re: [PATCH v3 08/14] ASoC: SOF: Add DSP HW abstraction operations

Mark Brown
2019-01-22T18:56:19Z

[-- Attachment #1.1: Type: text/plain, Size: 905 bytes --]

On Wed, Jan 09, 2019 at 03:37:26PM -0600, Pierre-Louis Bossart wrote:
> On 1/9/19 2:51 PM, Mark Brown wrote:
> > On Tue, Dec 11, 2018 at 03:23:12PM -0600, Pierre-Louis Bossart wrote:

> > > +int snd_sof_pci_update_bits_unlocked(struct snd_sof_dev *sdev, u32 offset,
> > > + u32 mask, u32 value)
> > > +{
> > > + bool change;
> > > + unsigned int old, new;
> > > + u32 ret = ~0; /* explicit init to remove uninitialized use warnings */

> > This looks a lot like you want to write regmap_pci_config...

> I think you made that note for the v2 a long time ago, not sure if I replied
> at the time.

> We only use this for 4 cases (power/clock gating on/off, traffic class, etc)
> and only during the hardware initialization. This is similar to the legacy
> and Skylake driver, I don't see a significant benefit with a regmap?

Mainly the debugfs stuff and trace I'd expect. It's not a requirement.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]