Re: [PATCH v3 02/14] ASoC: SOF: Add Sound Open Firmware KControl support

Andy Shevchenko
2018-12-11T22:23:08Z

On Tue, Dec 11, 2018 at 03:23:06PM -0600, Pierre-Louis Bossart wrote:
> From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
>
> SOF exposes regular ALSA Kcontrols that are defined by topology. This
> patch converts the Kcontrol IO to DSP IPC.
>
> The current implementation is not optimal and can be improved:
> a) for every get/put the host wakes up the DSP and generates an
> IPC. The kernel should cache the values and generate an IPC only when
> strictly necessary.
> b) the firmware can be implemented to only instantiate the pipelines
> and related control-related parts that are needed at a given time, and
> power-gate the relevant SRAM blocks.
>
> The development tasks for these two improvements has started, once
> validated they willl be provided in an update.

> + max_size = (be->max < max_size) ? be->max : max_size;

min() / max() ?

--
With Best Regards,
Andy Shevchenko