Re: [PATCH v3 02/14] ASoC: SOF: Add Sound Open Firmware KControl support

Pierre-Louis Bossart
2018-12-12T20:18:50Z

>> + max_size = (be->max < max_size) ? be->max : max_size;
> min() / max() ?
>
The use of min() and min3() seems to generate tons of sparse warnings
(see below), so I'll leave the code with an explicit test and a comment
stating why.

sparse helped us find quite a few issues with endianess, const, iomem
qualifiers, I'd like to keep it quiet on non-issues.

CHECK   sound/soc/sof/control.c
sound/soc/sof/control.c:300:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:300:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)
sound/soc/sof/control.c:396:20: warning: expression using sizeof(void)

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org