Re: [PATCH v3 07/14] ASoC: SOF: Add DSP firmware logger support

Mark Brown
2019-01-22T21:08:32Z

[-- Attachment #1.1: Type: text/plain, Size: 865 bytes --]

On Tue, Jan 22, 2019 at 02:52:25PM -0600, Pierre-Louis Bossart wrote:

> > I don't understand that warning - avail and count are both size_t so
> > where's it deciding that there's a void involved?

> no idea really, I am only a user of sparse, I don't know how it generated
> that warning.

Yeah, I use it quite a bit as well.

> there are equally confusing ones such as

> include/linux/slab.h:332:43: warning: dubious: x & !y

> include/linux/slab.h:665:13: warning: call with no type!

> include/linux/slab.h:665:13: error: undefined identifier
> '__builtin_mul_overflow

> The main benefit of sparse is that it is the only tool that found endianess
> and iomem space issues, but it's often buried in heaps of false alarms in
> include files.

It's got less and less useful as time goes on I think :( For this one
did you try reporting the bug to the authors?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]