Re: [Sound-open-firmware] [PATCH v3 13/14] ASoC: SOF: Add xtensa support

Mark Brown
2018-12-17T14:24:40Z

[-- Attachment #1.1: Type: text/plain, Size: 874 bytes --]

On Mon, Dec 17, 2018 at 02:45:49PM +0100, Takashi Iwai wrote:
> rander.wang wrote:

> > > [    3.250889] sof-audio sof-audio: 0x0049fbcc: 0x80005ac5
> > > 0x0049fc60 0x00000000 0x00000000

> > Add more details: we use another tool to analysis the hex numbers with
> > a ELF file to get the correct information, so we do it by ourself.

> If the format is intentional and shouldn't be changed to the generic
> one, this has to be mentioned in the code as some proper comment.

> The use of hex_dump_to_buffer() or whatever the standard macro is a
> "right thing" in general. From what I can see, the home-baked code
> does nothing but writing in 32bit words, so without the explanation,
> no one can see the reason to stick with it.

Or alternatively can the tool be changed to parse the more standard
format if it's not too hard to get people to update?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]