Re: [PATCH v3 02/14] ASoC: SOF: Add Sound Open Firmware KControl support

Andy Shevchenko
2018-12-11T23:25:44Z

On Tue, Dec 11, 2018 at 04:48:37PM -0600, Pierre-Louis Bossart wrote:
> > > + max_size = (be->max < max_size) ? be->max : max_size;
> > min() / max() ?
>
> Good catch, this can be simplified.
>
> Not sure I like max_size = min (be->max, max_size), it's confusing.

Hmm... It shows intention. For _max size_ you choose _minimum_ value out of two.

>
> Maybe
>
> if (be->max < max_size)
>
>     max_size = be->max;

It's minor, just choose one style and use it.

--
With Best Regards,
Andy Shevchenko