Re: [PATCH v3 07/14] ASoC: SOF: Add DSP firmware logger support

Mark Brown
2019-01-22T20:41:22Z

[-- Attachment #1.1: Type: text/plain, Size: 679 bytes --]

On Tue, Jan 22, 2019 at 02:33:55PM -0600, Pierre-Louis Bossart wrote:
>
> > > > > + /* make sure count is <= avail */
> > > > > + count = avail > count ? count : avail;
> > > > min()?

> > Why was sparse complaining - was it spotting something that is an actual
> > issue here and you've just masked the warning?

> It was about the use of typeof/sizeof() in min(), not an actual issue in the
> code

> sound/soc/sof/trace.c:90:17: warning: expression using sizeof(void)
> sound/soc/sof/trace.c:90:17: warning: expression using sizeof(void)

I don't understand that warning - avail and count are both size_t so
where's it deciding that there's a void involved?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]