From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [RFT][PATCH v2] gpiolib: acpi: Introduce ACPI_GPIO_QUIRK_ONLY_GPIOIO Date: Fri, 25 Jan 2019 19:44:42 +0200 Message-ID: <20190125174442.GR9224@smile.fi.intel.com> References: <20190109105245.25954-1-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Hans de Goede , Mika Westerberg , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , "Rafael J. Wysocki" , ACPI Devel Maling List , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Mark Brown , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , "linux-kernel@vger.kernel.org" List-Id: alsa-devel@alsa-project.org On Mon, Jan 21, 2019 at 02:03:09PM +0100, Linus Walleij wrote: > On Wed, Jan 9, 2019 at 11:52 AM Andy Shevchenko > wrote: > > > New quirk enforces search for GPIO based on its type, > > i.e. iterate over GpioIo resources only. > > > > Signed-off-by: Andy Shevchenko > > --- > > > > - it was sent few weeks ago to Hans for testing, but better to re-test > > - it's supposed to go via ASoC subsystem due to recent changes made for > > sound driver > > > > v2: > > - Expand explanation why this quirk might be needed (Mika) > > I tried to apply this but it doesn't apply on the GPIO devel > branch. > > I suppose because of Hans de Goede's > commit 72893f0c6bd399ce84e3c1c9fc69d234fe37d098 > Author: Hans de Goede > Date: Mon Dec 31 21:55:21 2018 +0100 > > gpiolib-acpi: Preserve non direction flags when updating gpiod_flags > > Could you rebase and resend? Linus, as I mentioned in comments above this should go via ASoC tree, there is no conflicts with gpio/devel for GPIO matters. So, please, give your Ack and hopefully Mark will apply this soon. > > (Also pick up Mika's ACK.) > > PS I'm a bit split about pure ACPI patches, part of me see it as an > "intel thing" so that you could very well collect it in the Intel > GPIO tree and send me pull requests, on the other hand it is > ACPI and sometimes applied in Rafael's tree. Maybe just as good > that I keep picking them separately like this? > > Yours, > Linus Walleij -- With Best Regards, Andy Shevchenko