From: Russell Parker <russell.parker7@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] UCM: bytcr/PlatformEnableSeq.conf update some comments
Date: Wed, 6 Feb 2019 18:42:46 -0800 [thread overview]
Message-ID: <20190207024246.GA31500@celes> (raw)
In-Reply-To: <20190203113741.15203-1-hdegoede@redhat.com>
On 02/03, Hans de Goede wrote:
> Commit f91cc3c7d6b7 ("Update chtrt5645 ucm variants to use
> bytcr/PlatformEnableSeq.conf component") updated the
> following 2 comments:
>
> # codec0_out settings (used if SSP2 is connected to aif1)
> # modem_out settings (used if SSP0 is connected to aif2)
>
> Specifically it added the " to aif1" resp. " to aif2" part of the comments.
>
> This is not correct, AIF1 / AIF2 are something which is present on
> Realtek codecs only, and either one can be used indepedent of
> SSP0 or SSP2 being used (the comments in the chtrt5645 UCM profile
> before this change were wrong / outdated).
>
> Besides there not being any relationship between SSP0 or SSP2 being
> used, bytcr/PlatformEnableSeq.conf is also used with other codecs,
> e.g. the ESS8316 codec where this is not applicable at all.
>
> Therefor this commit removes the " to aif?" part of the comments again
> to avoid confusing people reading this in the future.
>
> Cc: Russell Parker <russell.parker7@gmail.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Thanks for updating the comments; I saw that the notes were in the rt5645
sequences and incorrectly assumed that it applied to the platform too. Glad
you caught it!
next prev parent reply other threads:[~2019-02-07 2:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 11:37 [PATCH] UCM: bytcr/PlatformEnableSeq.conf update some comments Hans de Goede
2019-02-03 11:38 ` Hans de Goede
2019-02-07 2:42 ` Russell Parker [this message]
2019-02-07 7:22 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207024246.GA31500@celes \
--to=russell.parker7@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=hdegoede@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).