Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Waterlander <patrick.waterlander@intel.com>
To: patch@alsa-project.org
Cc: alsa-devel@alsa-project.org,
	Patrick Waterlander <patrick.waterlander@intel.com>
Subject: [PATCH 1/1] ASoC: Intel: Skylake: change list empty check to warning
Date: Thu, 25 Apr 2019 14:57:43 -0700	[thread overview]
Message-ID: <20190425215743.88673-1-patrick.waterlander@intel.com> (raw)

NULL is a valid state for the module list when querying unique ID.
Downgrade the empty condition from error to warning.

Signed-off-by: Patrick Waterlander <patrick.waterlander@intel.com>

diff --git a/sound/soc/intel/skylake/skl-sst.c b/sound/soc/intel/skylake/skl-sst.c
index 5951bbdf1f1a..95e6a23538cd 100644
--- a/sound/soc/intel/skylake/skl-sst.c
+++ b/sound/soc/intel/skylake/skl-sst.c
@@ -324,7 +324,7 @@ static struct skl_module_table *skl_module_get_from_id(
 	struct skl_module_table *module;
 
 	if (list_empty(&ctx->module_list)) {
-		dev_err(ctx->dev, "Module list is empty\n");
+		dev_warn(ctx->dev, "Module list is empty\n");
 		return NULL;
 	}
 
-- 
2.17.1

             reply	other threads:[~2019-04-25 21:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-25 21:57 Patrick Waterlander [this message]
2019-04-29 13:05 ` [PATCH 1/1] ASoC: Intel: Skylake: change list empty check to warning Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190425215743.88673-1-patrick.waterlander@intel.com \
    --to=patrick.waterlander@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=patch@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox