From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: broonie@kernel.org
Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
lgirdwood@gmail.com
Subject: [PATCH 1/2] ASoC: wm_adsp: Correct region base typo in wm_halo_setup_algs
Date: Wed, 1 May 2019 11:13:31 +0100 [thread overview]
Message-ID: <20190501101332.31190-1-ckeepax@opensource.cirrus.com> (raw)
Due to a typo the wrong base is being supplied for the primary algorithm
on Halo firmwares, which will cause the controls to not function.
Fixes: 170b1e123f38 ("ASoC: wm_adsp: Add support for new Halo core DSPs")
Reported-by: Stuart Henderson <stuarth@opensource.cirrus.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
sound/soc/codecs/wm_adsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
index a9298bfddd9c7..f3c28e54d6d6e 100644
--- a/sound/soc/codecs/wm_adsp.c
+++ b/sound/soc/codecs/wm_adsp.c
@@ -2445,7 +2445,7 @@ static int wm_halo_setup_algs(struct wm_adsp *dsp)
wmfw_v3_parse_id_header(dsp, &halo_id.fw, n_algs);
ret = wm_halo_create_regions(dsp, halo_id.fw.id,
- halo_id.ym_base, halo_id.ym_base);
+ halo_id.xm_base, halo_id.ym_base);
if (ret)
return ret;
--
2.11.0
next reply other threads:[~2019-05-01 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 10:13 Charles Keepax [this message]
2019-05-01 10:13 ` [PATCH 2/2] ASoC: wm_adsp: Use DSP ops pointers to stop watchdog in error handlers Charles Keepax
2019-05-02 2:18 ` Applied "ASoC: wm_adsp: Use DSP ops pointers to stop watchdog in error handlers" to the asoc tree Mark Brown
2019-05-02 2:18 ` Applied "ASoC: wm_adsp: Correct region base typo in wm_halo_setup_algs" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501101332.31190-1-ckeepax@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).