From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v4 00/22] soundwire: code cleanup Date: Thu, 2 May 2019 11:09:56 +0530 Message-ID: <20190502053956.GF3845@vkoul-mobl.Dlink> References: <20190501155745.21806-1-pierre-louis.bossart@linux.intel.com> <20190501160755.GC19281@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190501160755.GC19281@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg KH Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, liam.r.girdwood@linux.intel.com, jank@cadence.com, joe@perches.com, srinivas.kandagatla@linaro.org List-Id: alsa-devel@alsa-project.org On 01-05-19, 18:07, Greg KH wrote: > On Wed, May 01, 2019 at 10:57:23AM -0500, Pierre-Louis Bossart wrote: > > SoundWire support will be provided in Linux with the Sound Open > > Firmware (SOF) on Intel platforms. Before we start adding the missing > > pieces, there are a number of warnings and style issues reported by > > checkpatch, cppcheck and Coccinelle that need to be cleaned-up. > > > > Changes since v3: > > patch 1,3,4 were merged for 5.2-rc1 > > No code change, only split patch2 in 21 patches to make Vinod > > happy. Each patch only fixes a specific issue. patch 5 is now patch22 > > and wasn't changed. Not sure why Vinod reported the patch didn't > > apply. > > Added Takashi's Reviewed-by tag in all patches since the code is > > exactly the same as in v3. > > These all look good to me: > > Reviewed-by: Greg Kroah-Hartman > > Vinod, want me to just pick these up from the list as-is so we can get > them into 5.2-rc1? Thanks Greg, I would still like modification to patches that touch core subsystem parts and drivers in a single one. Otherwise changes are fine. So I will go ahead and apply the rest and send you a PR tomorrow giving a chance to Pierre to update these (ofcourse they will be in linux-next tomorrow) Thanks -- ~Vinod