From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v4 22/22] soundwire: add missing newlines in dynamic debug logs Date: Thu, 2 May 2019 08:32:19 +0200 Message-ID: <20190502063219.GB14347@kroah.com> References: <20190501155745.21806-1-pierre-louis.bossart@linux.intel.com> <20190501155745.21806-23-pierre-louis.bossart@linux.intel.com> <20190502053746.GE3845@vkoul-mobl.Dlink> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190502053746.GE3845@vkoul-mobl.Dlink> Sender: linux-kernel-owner@vger.kernel.org To: Vinod Koul Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, liam.r.girdwood@linux.intel.com, jank@cadence.com, joe@perches.com, srinivas.kandagatla@linaro.org, Sanyog Kale List-Id: alsa-devel@alsa-project.org On Thu, May 02, 2019 at 11:07:46AM +0530, Vinod Koul wrote: > On 01-05-19, 10:57, Pierre-Louis Bossart wrote: > > For some reason the newlines are not used everywhere. Fix as needed. > > > > Reported-by: Joe Perches > > Reviewed-by: Takashi Iwai > > Signed-off-by: Pierre-Louis Bossart > > --- > > drivers/soundwire/bus.c | 74 +++++++++---------- > > drivers/soundwire/cadence_master.c | 12 ++-- > > drivers/soundwire/intel.c | 12 ++-- > > drivers/soundwire/stream.c | 110 ++++++++++++++--------------- > > Sorry this needs to be split up. I think bus.c and stream.c should go > in patch with cadence_master.c and intel.c in different ones Again, _way_ too picky. You can't look a gift horse _too_ closely in the mouth... greg k-h