From: Nariman <narimantos@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: hdegoede@redhat.com, pierre-louis.bossart@linux.intel.com,
liam.r.girdwood@linux.intel.com, yang.jie@linux.intel.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org,
Damian van Soelen <dj.vsoelen@gmail.com>
Subject: [PATCH] ASoC: Intel: cht_bsw_rt5645.c: Remove buffer and snprintf calls
Date: Sat, 4 May 2019 17:16:50 +0200 [thread overview]
Message-ID: <20190504151652.5213-2-user@elitebook-localhost> (raw)
In-Reply-To: <20190504151652.5213-1-user@elitebook-localhost>
From: Damian van Soelen <dj.vsoelen@gmail.com>
The snprintf calls filling cht_rt5645_cpu_dai_name / cht_rt5645_codec_aif_name
always fill them with the same string ("ssp0-port" resp "rt5645-aif2") so
instead of keeping these buffers around and making the cpu_dai_name /
codec_aif_name point to this, simply update the foo_dai_name and foo_aif_name pointers to
directly point to a string constant containing the desired string.
Signed-off-by: Damian van Soelen <dj.vsoelen@gmail.com>
---
sound/soc/intel/boards/cht_bsw_rt5645.c | 26 ++++---------------------
1 file changed, 4 insertions(+), 22 deletions(-)
diff --git a/sound/soc/intel/boards/cht_bsw_rt5645.c b/sound/soc/intel/boards/cht_bsw_rt5645.c
index cbc2d458483f..b15459e56665 100644
--- a/sound/soc/intel/boards/cht_bsw_rt5645.c
+++ b/sound/soc/intel/boards/cht_bsw_rt5645.c
@@ -506,8 +506,6 @@ static struct cht_acpi_card snd_soc_cards[] = {
};
static char cht_rt5645_codec_name[SND_ACPI_I2C_ID_LEN];
-static char cht_rt5645_codec_aif_name[12]; /* = "rt5645-aif[1|2]" */
-static char cht_rt5645_cpu_dai_name[10]; /* = "ssp[0|2]-port" */
static bool is_valleyview(void)
{
@@ -641,28 +639,12 @@ static int snd_cht_mc_probe(struct platform_device *pdev)
log_quirks(&pdev->dev);
if ((cht_rt5645_quirk & CHT_RT5645_SSP2_AIF2) ||
- (cht_rt5645_quirk & CHT_RT5645_SSP0_AIF2)) {
-
- /* fixup codec aif name */
- snprintf(cht_rt5645_codec_aif_name,
- sizeof(cht_rt5645_codec_aif_name),
- "%s", "rt5645-aif2");
-
- cht_dailink[dai_index].codec_dai_name =
- cht_rt5645_codec_aif_name;
- }
+ (cht_rt5645_quirk & CHT_RT5645_SSP0_AIF2))
+ cht_dailink[dai_index].codec_dai_name = "rt5645-aif2";
if ((cht_rt5645_quirk & CHT_RT5645_SSP0_AIF1) ||
- (cht_rt5645_quirk & CHT_RT5645_SSP0_AIF2)) {
-
- /* fixup cpu dai name name */
- snprintf(cht_rt5645_cpu_dai_name,
- sizeof(cht_rt5645_cpu_dai_name),
- "%s", "ssp0-port");
-
- cht_dailink[dai_index].cpu_dai_name =
- cht_rt5645_cpu_dai_name;
- }
+ (cht_rt5645_quirk & CHT_RT5645_SSP0_AIF2))
+ cht_dailink[dai_index].cpu_dai_name = "ssp0-port";
/* override plaform name, if required */
platform_name = mach->mach_params.platform;
--
2.20.1
next prev parent reply other threads:[~2019-05-04 15:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 15:16 [PATCH] ASoC: Intel: bytcr_5640.c:Refactored if statement and removed buffer Nariman
2019-05-04 15:16 ` Nariman [this message]
2019-05-06 15:24 ` [alsa-devel] [PATCH] ASoC: Intel: cht_bsw_rt5645.c: Remove buffer and snprintf calls Pierre-Louis Bossart
2019-05-06 15:48 ` Hans de Goede
2019-05-04 15:16 ` [PATCH] ASoC: Intel: bytcr_5640.c: refactored codec_fixup Nariman
2019-05-04 15:16 ` [PATCH] ASoC: Intel: bytcr_rt5651.c: remove string buffers 'byt_rt5651_cpu_dai_name' and 'byt_rt5651_cpu_dai_name' Nariman
2019-05-05 7:51 ` Takashi Iwai
2019-05-06 15:40 ` Hans de Goede
2019-05-06 15:50 ` Pierre-Louis Bossart
2019-05-06 15:24 ` Pierre-Louis Bossart
2019-05-06 15:21 ` [alsa-devel] [PATCH] ASoC: Intel: bytcr_5640.c:Refactored if statement and removed buffer Pierre-Louis Bossart
2019-05-06 15:43 ` Hans de Goede
2019-05-06 15:50 ` Pierre-Louis Bossart
-- strict thread matches above, loose matches on Subject: below --
2019-05-19 17:57 nariman
2019-05-19 17:57 ` [PATCH] ASoC: Intel: cht_bsw_rt5645.c: Remove buffer and snprintf calls nariman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190504151652.5213-2-user@elitebook-localhost \
--to=narimantos@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dj.vsoelen@gmail.com \
--cc=hdegoede@redhat.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).