From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Flax Subject: [PATCH] ASoC : cs4265 : readable register too low Date: Wed, 8 May 2019 16:33:13 +1000 Message-ID: <20190508063313.18099-1-flatmax@flatmax.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from pecan.exetel.com.au (pecan-mail.exetel.com.au [220.233.0.8]) by alsa1.perex.cz (Postfix) with ESMTP id E6AEAF807B5 for ; Wed, 8 May 2019 08:33:24 +0200 (CEST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Liam Girdwood , Mark Brown , Brian Austin , Paul Handrigan , clemens@ladisch.de, ckeepax@opensource.cirrus.com, alsa-devel@alsa-project.org Cc: Matt Flax List-Id: alsa-devel@alsa-project.org The cs4265_readable_register function stopped short of the maximum register. An example bug is taken from : https://github.com/Audio-Injector/Ultra/issues/25 Where alsactl store fails with : Cannot read control '2,0,0,C Data Buffer,0': Input/output error This patch fixes the bug by setting the cs4265 to have readable registers up to the maximum hardware register CS4265_MAX_REGISTER. Signed-off-by: Matt Flax --- sound/soc/codecs/cs4265.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs4265.c b/sound/soc/codecs/cs4265.c index ab27d2b94d02..c0190ec59e74 100644 --- a/sound/soc/codecs/cs4265.c +++ b/sound/soc/codecs/cs4265.c @@ -60,7 +60,7 @@ static const struct reg_default cs4265_reg_defaults[] = { static bool cs4265_readable_register(struct device *dev, unsigned int reg) { switch (reg) { - case CS4265_CHIP_ID ... CS4265_SPDIF_CTL2: + case CS4265_CHIP_ID ... CS4265_MAX_REGISTER: return true; default: return false; -- 2.19.1