From: codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
wens-jdAy2FN1RRM@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
be17068-p0aYb1w59bq9tCD/VL7h6Q@public.gmane.org,
Marcus Cooper
<codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: [PATCH v4 1/9] ASoC: sun4i-i2s: Fix sun8i tx channel offset mask
Date: Mon, 3 Jun 2019 19:47:27 +0200 [thread overview]
Message-ID: <20190603174735.21002-2-codekipper@gmail.com> (raw)
In-Reply-To: <20190603174735.21002-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Although not causing any noticeable issues, the mask for the
channel offset is covering too many bits.
Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
sound/soc/sunxi/sun4i-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index c53bfed8d4c2..90bd3963d8ae 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -106,7 +106,7 @@
#define SUN8I_I2S_TX_CHAN_MAP_REG 0x44
#define SUN8I_I2S_TX_CHAN_SEL_REG 0x34
-#define SUN8I_I2S_TX_CHAN_OFFSET_MASK GENMASK(13, 11)
+#define SUN8I_I2S_TX_CHAN_OFFSET_MASK GENMASK(13, 12)
#define SUN8I_I2S_TX_CHAN_OFFSET(offset) (offset << 12)
#define SUN8I_I2S_TX_CHAN_EN_MASK GENMASK(11, 4)
#define SUN8I_I2S_TX_CHAN_EN(num_chan) (((1 << num_chan) - 1) << 4)
--
2.21.0
next prev parent reply other threads:[~2019-06-03 17:47 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 17:47 [PATCH v4 0/9]ASoC: sun4i-i2s: Updates to the driver codekipper-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20190603174735.21002-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-03 17:47 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w [this message]
[not found] ` <20190603174735.21002-2-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-04 7:34 ` [PATCH v4 1/9] ASoC: sun4i-i2s: Fix sun8i tx channel offset mask Maxime Ripard
2019-06-04 7:38 ` Chen-Yu Tsai
2019-06-04 8:15 ` [linux-sunxi] " Code Kipper
2019-06-04 14:58 ` Applied "ASoC: sun4i-i2s: Fix sun8i tx channel offset mask" to the asoc tree Mark Brown
2019-06-03 17:47 ` [PATCH v4 2/9] ASoC: sun4i-i2s: Add offset to RX channel select codekipper-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20190603174735.21002-3-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-04 7:36 ` Maxime Ripard
2019-06-04 7:39 ` Chen-Yu Tsai
2019-06-04 14:58 ` Applied "ASoC: sun4i-i2s: Add offset to RX channel select" to the asoc tree Mark Brown
2019-06-03 17:47 ` [PATCH v4 4/9] ASoC: sun4i-i2s: Reduce quirks for sun8i-h3 codekipper-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20190603174735.21002-5-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-04 7:46 ` Maxime Ripard
2019-06-04 9:33 ` Code Kipper
2019-06-03 17:47 ` [PATCH v4 5/9] ASoC: sun4i-i2s: Add set_tdm_slot functionality codekipper-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20190603174735.21002-6-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-04 7:49 ` Maxime Ripard
2019-06-03 17:47 ` [PATCH v4 6/9] ASoC: sun4i-i2s: Add multi-lane functionality codekipper-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20190603174735.21002-7-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-04 7:58 ` Maxime Ripard
2019-06-04 8:43 ` Code Kipper
[not found] ` <CAEKpxB=RdYF9eEvAJ+R7sT6OtdtBWjhMM1am+EhaN=9ZO9Gd2A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-04 9:02 ` Christopher Obbard
[not found] ` <CAP03XepJVPge5sz4WcmK8pp2jHAPJdGb6v6A3R0DzSf5O6qj-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-04 9:38 ` Code Kipper
[not found] ` <CAEKpxBmxAQKgDhvjpczAWwNtNhYRs07wjMSnr8nqHk1XxMT=nw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-07-30 17:57 ` Jernej Škrabec
2019-07-31 12:29 ` Maxime Ripard
2019-08-01 5:31 ` [linux-sunxi] " Jernej Škrabec
2019-08-06 6:22 ` Chen-Yu Tsai
[not found] ` <CAGb2v66D4-QvWYPXE=rf6Zv93X1LjnxUgpk+5wdAL_b7MM3vaA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-08-12 10:02 ` Maxime Ripard
2019-06-03 17:47 ` [PATCH v4 7/9] ASoC: sun4i-i2s: Add multichannel functionality codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-06-03 17:47 ` [PATCH v4 8/9] ASoc: sun4i-i2s: Add 20, 24 and 32 bit support codekipper-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20190603174735.21002-9-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-04 8:19 ` Maxime Ripard
2019-06-03 17:47 ` [PATCH v4 9/9] ASoC: sun4i-i2s: Adjust regmap settings codekipper-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20190603174735.21002-10-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-04 8:21 ` Maxime Ripard
2019-06-03 17:47 ` [PATCH v4 3/9] ASoC: sun4i-i2s: Add regmap field to sign extend sample codekipper
[not found] ` <20190603174735.21002-4-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-04 7:43 ` Maxime Ripard
2019-06-04 7:53 ` [linux-sunxi] " Chen-Yu Tsai
2019-06-04 11:46 ` Code Kipper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603174735.21002-2-codekipper@gmail.com \
--to=codekipper-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=be17068-p0aYb1w59bq9tCD/VL7h6Q@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).