Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	wens-jdAy2FN1RRM@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	be17068-p0aYb1w59bq9tCD/VL7h6Q@public.gmane.org,
	Marcus Cooper
	<codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: [PATCH v5 06/15] ASoC: sun4i-i2s: Add functions for RX and TX channel enables
Date: Wed, 14 Aug 2019 08:08:45 +0200	[thread overview]
Message-ID: <20190814060854.26345-7-codekipper@gmail.com> (raw)
In-Reply-To: <20190814060854.26345-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Newer SoCs like the H6 have the channel enable bits in a different
position to what is on the H3. As we will eventually add multi-
channel support then create function calls as opposed to regmap
fields to add support for different devices.

Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 sound/soc/sunxi/sun4i-i2s.c | 32 ++++++++++++++++++++++++++++----
 1 file changed, 28 insertions(+), 4 deletions(-)

diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 4a748747ccd7..ad2ff83deeb7 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -172,6 +172,8 @@ struct sun4i_i2s_quirks {
 	int	(*set_format)(struct sun4i_i2s *, unsigned int);
 	void	(*set_txchanoffset)(const struct sun4i_i2s *, int);
 	void	(*set_rxchanoffset)(const struct sun4i_i2s *);
+	void	(*set_txchanen)(const struct sun4i_i2s *, int, int);
+	void	(*set_rxchanen)(const struct sun4i_i2s *, int);
 };
 
 struct sun4i_i2s {
@@ -444,6 +446,25 @@ static void sun8i_i2s_set_rxchanoffset(const struct sun4i_i2s *i2s)
 			   SUN8I_I2S_TX_CHAN_OFFSET(i2s->offset));
 }
 
+static void sun8i_i2s_set_txchanen(const struct sun4i_i2s *i2s, int output,
+				   int channel)
+{
+	if (output >= 0 && output < 4) {
+		regmap_update_bits(i2s->regmap,
+				   SUN8I_I2S_TX_CHAN_SEL_REG + (output * 4),
+				   SUN8I_I2S_TX_CHAN_EN_MASK,
+				   SUN8I_I2S_TX_CHAN_EN(channel));
+	}
+}
+
+static void sun8i_i2s_set_rxchanen(const struct sun4i_i2s *i2s, int channel)
+{
+	regmap_update_bits(i2s->regmap,
+			   SUN8I_I2S_RX_CHAN_SEL_REG,
+			   SUN8I_I2S_TX_CHAN_EN_MASK,
+			   SUN8I_I2S_TX_CHAN_EN(channel));
+}
+
 static int sun4i_i2s_hw_params(struct snd_pcm_substream *substream,
 			       struct snd_pcm_hw_params *params,
 			       struct snd_soc_dai *dai)
@@ -479,10 +500,11 @@ static int sun4i_i2s_hw_params(struct snd_pcm_substream *substream,
 	regmap_field_write(i2s->field_rxchansel,
 			   SUN4I_I2S_CHAN_SEL(params_channels(params)));
 
-	if (i2s->variant->has_chsel_tx_chen)
-		regmap_update_bits(i2s->regmap, SUN8I_I2S_TX_CHAN_SEL_REG,
-				   SUN8I_I2S_TX_CHAN_EN_MASK,
-				   SUN8I_I2S_TX_CHAN_EN(channels));
+	if (i2s->variant->set_txchanen)
+		i2s->variant->set_txchanen(i2s, 0, channels);
+
+	if (i2s->variant->set_rxchanen)
+		i2s->variant->set_rxchanen(i2s, channels);
 
 	switch (params_physical_width(params)) {
 	case 16:
@@ -1098,6 +1120,8 @@ static const struct sun4i_i2s_quirks sun8i_h3_i2s_quirks = {
 	.set_format		= sun8i_i2s_set_format,
 	.set_txchanoffset	= sun8i_i2s_set_txchanoffset,
 	.set_rxchanoffset	= sun8i_i2s_set_rxchanoffset,
+	.set_txchanen		= sun8i_i2s_set_txchanen,
+	.set_rxchanen		= sun8i_i2s_set_rxchanen,
 };
 
 static const struct sun4i_i2s_quirks sun50i_a64_codec_i2s_quirks = {
-- 
2.22.0

  parent reply	other threads:[~2019-08-14  6:08 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14  6:08 [PATCH v5 00/15] ASoC: sun4i-i2s: Updates to the driver codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found] ` <20190814060854.26345-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-08-14  6:08   ` [PATCH v5 01/15] ASoC: sun4i-i2s: Add regmap field to sign extend sample codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14  6:43     ` Maxime Ripard
2019-08-14 11:24       ` Code Kipper
2019-08-14  6:08   ` [PATCH v5 02/15] ASoC: sun4i-i2s: Add set_tdm_slot functionality codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <20190814060854.26345-3-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-08-14  7:09       ` Maxime Ripard
2019-08-16  6:27         ` Code Kipper
2019-08-14  9:30       ` Mark Brown
     [not found]         ` <20190814093011.GD4640-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2019-08-16  6:22           ` Code Kipper
2019-08-14  6:08   ` [PATCH v5 03/15] ASoC: sun4i-i2s: Correct divider calculations codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <20190814060854.26345-4-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-08-14  7:13       ` Maxime Ripard
2019-08-14  9:31       ` Mark Brown
2019-08-14  6:08   ` [PATCH v5 04/15] ASoC: sun4i-i2s: Support more formats on newer SoCs codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <20190814060854.26345-5-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-08-14  7:16       ` Maxime Ripard
2019-08-14 11:23         ` Code Kipper
2019-08-14  6:08   ` [PATCH v5 05/15] ASoC: sun4i-i2s: Add functions for RX and TX channel offsets codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14  6:08   ` codekipper-Re5JQEeQqe8AvxtiuMwx3w [this message]
2019-08-14  6:08   ` [PATCH v5 07/15] ASoC: sun4i-i2s: Add functions for RX and TX channel selects codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14  6:08   ` [PATCH v5 08/15] ASoC: sun4i-i2s: Add functions for channel mapping codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14  6:08   ` [PATCH v5 09/15] clk: sunxi-ng: h6: Allow I2S to change parent rate codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <20190814060854.26345-10-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-08-21  4:07       ` Chen-Yu Tsai
     [not found]         ` <CAGb2v65+-OB4zEyW8f7hcWHkL7DtfEB1YK2B1nOKdgNdNqC0kQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-08-21  5:52           ` Code Kipper
     [not found]             ` <CAEKpxBnxf=iejk887A7qFkzt3BXVxiRS1PeA45aZYR9DsBAU4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-08-21  6:01               ` Chen-Yu Tsai
2019-08-21  9:19       ` Code Kipper
     [not found]         ` <CAEKpxB=9NNoZgZoY_GpcEuDYoMUGzb+ATgZOSM64qy9tirC_MQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-08-21  9:35           ` Chen-Yu Tsai
2019-08-14  6:08   ` [PATCH v5 10/15] dt-bindings: ASoC: sun4i-i2s: Add H6 compatible codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14  6:08   ` [PATCH v5 11/15] ASoC: sun4i-i2s: Add support for H6 I2S codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <20190814060854.26345-12-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-08-14  7:57       ` Jernej Škrabec
2019-08-14 11:08         ` Code Kipper
2019-08-14  6:08   ` [PATCH v5 12/15] ASoC: sun4i-i2s: Add multi-lane functionality codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <20190814060854.26345-13-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-08-14  7:20       ` Maxime Ripard
2019-08-14 11:16         ` Code Kipper
2019-08-14  8:27       ` Jernej Škrabec
2019-08-14  6:08   ` [PATCH v5 13/15] ASoC: sun4i-i2s: Add multichannel functionality codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-08-14  6:08   ` [PATCH v5 14/15] ASoc: sun4i-i2s: Add 20, 24 and 32 bit support codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <20190814060854.26345-15-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-08-14  8:28       ` Jernej Škrabec
2019-08-14  9:03         ` Code Kipper
2019-08-14  6:08   ` [PATCH v5 15/15] ASoC: sun4i-i2s: Adjust regmap settings codekipper-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <20190814060854.26345-16-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-08-14  7:20       ` Maxime Ripard
2019-08-14 11:31         ` [linux-sunxi] " Jernej Škrabec
2019-08-14  8:37       ` Jernej Škrabec
2019-08-14  9:02         ` Code Kipper
2019-08-14 11:31     ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190814060854.26345-7-codekipper@gmail.com \
    --to=codekipper-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=be17068-p0aYb1w59bq9tCD/VL7h6Q@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox