Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jiaxin Yu <jiaxin.yu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	ck.hu-c+3QU6Y0cdFWk0Htik3J/w@public.gmane.org,
	lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	perex-/Fr2/VpizcU@public.gmane.org,
	tzungbi-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	eason.yen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH 2/2] ASoC: mediatek: mt8183: fix tdm out issue
Date: Thu, 22 Aug 2019 17:13:35 +0100	[thread overview]
Message-ID: <20190822161335.GA23391@sirena.co.uk> (raw)
In-Reply-To: <1566478261-13464-3-git-send-email-jiaxin.yu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 510 bytes --]

On Thu, Aug 22, 2019 at 08:51:01PM +0800, Jiaxin Yu wrote:
> This patch fix two tdm out issues.
> 1. TDM out support S16_LE/S24_LE/S32_LE formats .When output S32_LE, we
>    need set hd_align so that memif can output MSB 24bits correctly.
> 2. Fix TDM out hw_params as SNDRV_PCM_FORMAT_S32_LE.
> 3. Fix TDM out data is valid on rising edge.

These should really be split up into separate patches, each
fixing a single issue.  Ideally the changelog should describe
how the issue is fixed like that for 1 does.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 200 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

      parent reply	other threads:[~2019-08-22 16:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22 12:50 [PATCH 0/2] ASoC: MediaTek: fix mt8183-mt6358 tdm out issues Jiaxin Yu
     [not found] ` <1566478261-13464-1-git-send-email-jiaxin.yu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-08-22 12:51   ` [PATCH 1/2] ASoC: mediatek: mt8183: switch tdm pins gpio function when playback on or off Jiaxin Yu
     [not found]     ` <1566478261-13464-2-git-send-email-jiaxin.yu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-08-22 18:32       ` Applied "ASoC: mediatek: mt8183: switch tdm pins gpio function when playback on or off" to the asoc tree Mark Brown
2019-08-22 12:51   ` [PATCH 2/2] ASoC: mediatek: mt8183: fix tdm out issue Jiaxin Yu
     [not found]     ` <1566478261-13464-3-git-send-email-jiaxin.yu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-08-22 16:13       ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190822161335.GA23391@sirena.co.uk \
    --to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=ck.hu-c+3QU6Y0cdFWk0Htik3J/w@public.gmane.org \
    --cc=eason.yen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=jiaxin.yu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=perex-/Fr2/VpizcU@public.gmane.org \
    --cc=tzungbi-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox