From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E34E2C4360C for ; Fri, 27 Sep 2019 15:34:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69A9C217D7 for ; Fri, 27 Sep 2019 15:34:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="XsTC7uSa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69A9C217D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9B29B1614; Fri, 27 Sep 2019 17:33:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9B29B1614 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1569598446; bh=2mIweqEBNMgSHi8p5DJ7wb7dNIKe2IlXozYl5L7oym4=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XsTC7uSaaYHrAiPHSBsEoZO/b3RyRKcrnA3HBdwD9/EPfTshpWHpGDFe0cYylNsdI GWcMUF1WX1ZuWxyluOc4yYphVuxKizxKVL4Pw12ZtFmsFyJB2iARXOmtvDZ7ezclG/ dJCjfllmsxVqHm3pLXlpFlgRpBx4R22W4tR2WmJA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 33FB3F800B3; Fri, 27 Sep 2019 17:33:16 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 68AB6F804CA; Fri, 27 Sep 2019 17:33:15 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 12A07F8044C for ; Fri, 27 Sep 2019 17:33:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 12A07F8044C X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2019 08:33:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,555,1559545200"; d="scan'208";a="194521052" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006.jf.intel.com with ESMTP; 27 Sep 2019 08:33:05 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1iDsEy-0001S5-2b; Fri, 27 Sep 2019 18:33:04 +0300 Date: Fri, 27 Sep 2019 18:33:04 +0300 From: Andy Shevchenko To: Cezary Rojewski Message-ID: <20190927153304.GS32742@smile.fi.intel.com> References: <20190925161922.22479-1-navid.emamdoost@gmail.com> <13f4bd40-dbaa-e24e-edca-4b4acff9d9c5@linux.intel.com> <20190927025526.GD22969@cs-dulles.cs.umn.edu> <6966df25-e82c-1abe-6a0f-ff497dcda23b@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6966df25-e82c-1abe-6a0f-ff497dcda23b@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org, Greg Kroah-Hartman , Jie Yang , Mark Brown , Takashi Iwai , kjlu@umn.edu, Pierre-Louis Bossart , Liam Girdwood , emamd001@umn.edu, smccaman@umn.edu, Thomas Gleixner , Enrico Weigelt , linux-kernel@vger.kernel.org, Navid Emamdoost Subject: Re: [alsa-devel] [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Sep 27, 2019 at 05:10:18PM +0200, Cezary Rojewski wrote: > I'm fine with solution #1 as I guess asking to wait for refactor is not an > option. Code deployment is delayed due to range of administrative decisions, > some of which should be uncovered on alsa-devel soon enough. The problem with solution #1 is freeing orphaned pointer. It will work, but it's simple is not okay from object life time prospective. -- With Best Regards, Andy Shevchenko _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel