From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F26C10F14 for ; Thu, 10 Oct 2019 15:37:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30737206B6 for ; Thu, 10 Oct 2019 15:37:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="VV85DTkt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="Iz/io2pg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30737206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 10D851615; Thu, 10 Oct 2019 17:36:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 10D851615 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1570721841; bh=SQSmOLPkKZ0Y7BQiTH6KdWL7K8aMZRMH2w1mH5YCdmI=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VV85DTktlX0eiEKrYStFJM8BqFKpmVPH5ogbUuiis2Eoz8lVicirN04JZD+QKKHiG 3mYf2SmKUNkWKEoAmZiRgSBApNua/8tZVA+OpvcAnMvrHpjMn/IsBSp3pmjc6xU20K KQTZFXSeiewVAqn8ytHBWyhbJtWDP78ZHAQ0LoXQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8E4E4F80322; Thu, 10 Oct 2019 17:36:30 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C8ECAF8038F; Thu, 10 Oct 2019 17:36:28 +0200 (CEST) Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 99BA1F80113 for ; Thu, 10 Oct 2019 17:36:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 99BA1F80113 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="Iz/io2pg" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2/Z72vhQfofZgrUoDB8P7NRCh26TBlQoE03PoYj0MXI=; b=Iz/io2pg5tjKfpJv047LKyETQ /u6Y4/0sHpqyTvN5CIgOiJXRZaY2Uh7im74Tpn5IebUdJIWgwgUcffrHt0OLNvir9Aj6qtAfu/q30 RHM0XWcOjBjc0xqxOW/Nxpzfsvt7U6q4ls+vXMS1bim15mzaEq8IsTzcWvWNhHujwmRl8=; Received: from fw-tnat-cam3.arm.com ([217.140.106.51] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iIaUK-0001tW-FG; Thu, 10 Oct 2019 15:36:24 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id EBE05D00041; Thu, 10 Oct 2019 16:36:23 +0100 (BST) Date: Thu, 10 Oct 2019 16:36:23 +0100 From: Mark Brown To: "Sa, Nuno" Message-ID: <20191010153623.GD4741@sirena.org.uk> References: <20191010074234.7344-1-nuno.sa@analog.com> <20191010140512.GT2036@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: Void where prohibited by law. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , "lars@metafoo.de" , "lgirdwood@gmail.com" , "tiwai@suse.com" , "robh+dt@kernel.org" Subject: Re: [alsa-devel] [PATCH v3 1/2] ASOC: Add ADAU7118 8 Channel PDM-to-I2S/TDM Converter driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7422698485774087882==" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --===============7422698485774087882== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5p8PegU4iirBW1oA" Content-Disposition: inline --5p8PegU4iirBW1oA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 10, 2019 at 03:05:24PM +0000, Sa, Nuno wrote: > On Thu, 2019-10-10 at 15:05 +0100, Mark Brown wrote: > > You could use regulator_bulk_enable() here (and similarly on > > disable) but it doesn't fundamentally matter - they do guarantee > > that they'll do things in sequence, though they don't wait for > > the ramp to complete before kicking off the next enable in the > > sequence which can be an issue for some hardware. > Yes, regulator_bulk_enable() could fit. The only thing that worries me > is that we only check for errors returned from regulator_enable() after > all async work is done (which is probably what you mean by "they don't > wait for the ramp to complete before kicking off the next enable...") > which could leave us with DVDD applied without IOVDD for a short amount > of time. I'm not sure this would be a really issue and that would > damage the HW, but from what I can tell from the datasheet, It's not > advised to apply DVDD without IOVDD. Yeah, exactly. OTOH things like that (especially for brief time periods) are much more likely to result in the chip being in some weird state on init which won't matter if we immediately power off than anything else. Like I say it's not a requirement to use bulk operations. --5p8PegU4iirBW1oA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl2fT/cACgkQJNaLcl1U h9Dt7gf/ZvUHZZNHq/t4g3RlSNysGA0NnGbqqC9iVDNUYtHm0yFv2ah5wg+ep56/ l4Hd2Z8Wikrf9rQfgfgAyvGkFDAqMZqchLf03KZu614f1qmUe9iwSDnszQT17mwl mtQgoy+FzkZNKZdHGTHSfTxyZLlktWDZtAk//ucTOchkq2SiLree8x96Bd0+yvHZ UQns3/11BrVtXyoj8T1wldhKfnv9mhG4A2BJSKsoxLSwMRv3KhuGtwD2fDMI2r83 bT3Z9ATm/z+EUftbBzNRK55l1q2xCgW2L2Cx+QN3foKOYp1xxvZp/0IkTohu+9mm QCCHmaMkEfcWM4VQFFrQ5HUf+ClDqQ== =W1nX -----END PGP SIGNATURE----- --5p8PegU4iirBW1oA-- --===============7422698485774087882== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --===============7422698485774087882==--