From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3ECBC47404 for ; Fri, 11 Oct 2019 05:53:47 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1FDD2196E for ; Fri, 11 Oct 2019 05:53:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="JAN8oTMR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1FDD2196E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5A4571612; Fri, 11 Oct 2019 07:52:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5A4571612 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1570773224; bh=AcxECySIgMiLw0J6MH1xh2Gl7SH8T1hwR/dfKQQv18k=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JAN8oTMR97/n9TGWvBDnwDztX3F1Y4how1luamEhnAIPxnhKuY3/T13Lj7EI24Vkq ntl9KIApTgAsUakR4H53twH2BYpnoBykbzAv6KTEVAQboKsMPdTQTyBbjnR0UOZSlH VwwVsGHgPhyU6hKvpTZ0JzxwKH/cSl0/z1YDgdkM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DE70AF80113; Fri, 11 Oct 2019 07:52:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D53C9F802BE; Fri, 11 Oct 2019 07:52:35 +0200 (CEST) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 696D2F80113 for ; Fri, 11 Oct 2019 07:52:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 696D2F80113 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iInqC-0008KX-1r; Fri, 11 Oct 2019 07:51:52 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iInq9-0001Vy-3U; Fri, 11 Oct 2019 07:51:49 +0200 Date: Fri, 11 Oct 2019 07:51:49 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Arnd Bergmann Message-ID: <20191011055149.4dudr4tk2znpt65u@pengutronix.de> References: <20191010202802.1132272-1-arnd@arndb.de> <20191010203043.1241612-1-arnd@arndb.de> <20191010203043.1241612-11-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191010203043.1241612-11-arnd@arndb.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Cc: Ulf Hansson , Liam Girdwood , linus.walleij@linaro.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Thierry Reding , Sylwester Nawrocki , Mauro Carvalho Chehab , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Kukjin Kim , =?iso-8859-1?Q?Cl=E9ment_P=E9ron?= , linux-serial@vger.kernel.org, Jiri Slaby , linux-pwm@vger.kernel.org, Bartlomiej Zolnierkiewicz , Sascha Hauer , Mark Brown , linux-arm-kernel@lists.infradead.org, Sangbeom Kim , Greg Kroah-Hartman , linux-mmc@vger.kernel.org, Takashi Iwai , linux-spi@vger.kernel.org, Faiz Abbas , Olof Johansson Subject: Re: [alsa-devel] [PATCH 11/36] ARM: s5pv210: split from plat-samsung X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Oct 10, 2019 at 10:29:55PM +0200, Arnd Bergmann wrote: > These can be build completely independently, so split > the two Kconfig symbols. > = > Signed-off-by: Arnd Bergmann I'd mention the two symbols' names you're working on in the commit log. I guess it's about PLAT_SAMSUNG and ARCH_S5PV210. And I wouldn't call it "split" which IMHO suggests there was only one symbol before. Maybe: Don't imply PLAT_SAMSUNG if ARCH_S5PV210 is enabled would be a better subject line? > --- > arch/arm/Kconfig.debug | 6 +++--- > arch/arm/Makefile | 1 - > arch/arm/plat-samsung/Kconfig | 2 +- > drivers/mmc/host/Kconfig | 2 +- > drivers/pwm/Kconfig | 2 +- > drivers/spi/Kconfig | 2 +- > drivers/tty/serial/Kconfig | 2 +- > sound/soc/samsung/Kconfig | 2 +- > 8 files changed, 9 insertions(+), 10 deletions(-) > = > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index 9c4f2d6deb06..4c4e97ae4fcb 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -998,7 +998,7 @@ choice > via SCIFA4 on Renesas SH-Mobile AG5 (SH73A0). > = > config DEBUG_S3C_UART0 > - depends on PLAT_SAMSUNG || ARCH_EXYNOS > + depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS > select DEBUG_EXYNOS_UART if ARCH_EXYNOS > select DEBUG_S3C24XX_UART if ARCH_S3C24XX > select DEBUG_S3C64XX_UART if ARCH_S3C64XX > @@ -1010,7 +1010,7 @@ choice > by the boot-loader before use. > = > config DEBUG_S3C_UART1 > - depends on PLAT_SAMSUNG || ARCH_EXYNOS > + depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS > select DEBUG_EXYNOS_UART if ARCH_EXYNOS > select DEBUG_S3C24XX_UART if ARCH_S3C24XX > select DEBUG_S3C64XX_UART if ARCH_S3C64XX > @@ -1022,7 +1022,7 @@ choice > by the boot-loader before use. > = > config DEBUG_S3C_UART2 > - depends on PLAT_SAMSUNG || ARCH_EXYNOS > + depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS > select DEBUG_EXYNOS_UART if ARCH_EXYNOS > select DEBUG_S3C24XX_UART if ARCH_S3C24XX > select DEBUG_S3C64XX_UART if ARCH_S3C64XX > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > index f492d7c338fe..a1bc15cda751 100644 > --- a/arch/arm/Makefile > +++ b/arch/arm/Makefile > @@ -235,7 +235,6 @@ machine-$(CONFIG_PLAT_SPEAR) +=3D spear > # by CONFIG_* macro name. > plat-$(CONFIG_ARCH_OMAP) +=3D omap > plat-$(CONFIG_ARCH_S3C64XX) +=3D samsung > -plat-$(CONFIG_ARCH_S5PV210) +=3D samsung Would it make more sense to make this plat-$(PLAT_SAMSUNG) +=3D samsung (in a separate patch)? Hmm, it seems there is no plat-y for PLAT_S3C24XX=3Dy builds. Is this intended? If yes, the directory name containing "samsung" suggests something that seems untrue. Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel