From: Rikard Falkeborn <rikard.falkeborn@gmail.com>
To: dmurphy@ti.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.com, navada@ti.com, lgirdwood@gmail.com,
broonie@kernel.org, Rikard Falkeborn <rikard.falkeborn@gmail.com>
Subject: [alsa-devel] [PATCH] ASoC: tas2562: Fix misuse of GENMASK macro
Date: Tue, 15 Oct 2019 22:09:00 +0200 [thread overview]
Message-ID: <20191015200900.25798-1-rikard.falkeborn@gmail.com> (raw)
In-Reply-To: <20191008181517.5332-2-dmurphy@ti.com>
Arguments are supposed to be ordered high then low.
Fixes: c173dba44c2d ("ASoC: tas2562: Introduce the TAS2562 amplifier")
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
Spotted when trying to introduce compile time checking that the order
of the arguments to GENMASK are correct [0]. I have only compile tested
the patch.
[0]: https://lore.kernel.org/lkml/20191009214502.637875-1-rikard.falkeborn@gmail.com/
sound/soc/codecs/tas2562.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tas2562.h b/sound/soc/codecs/tas2562.h
index 60f2bb1d198b..62e659ab786d 100644
--- a/sound/soc/codecs/tas2562.h
+++ b/sound/soc/codecs/tas2562.h
@@ -62,7 +62,7 @@
#define TAS2562_TDM_CFG2_RIGHT_JUSTIFY BIT(6)
-#define TAS2562_TDM_CFG2_RXLEN_MASK GENMASK(0, 1)
+#define TAS2562_TDM_CFG2_RXLEN_MASK GENMASK(1, 0)
#define TAS2562_TDM_CFG2_RXLEN_16B 0x0
#define TAS2562_TDM_CFG2_RXLEN_24B BIT(0)
#define TAS2562_TDM_CFG2_RXLEN_32B BIT(1)
--
2.23.0
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-17 6:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 18:15 [alsa-devel] [PATCH 1/2] ASoc: Add Texas Instruments TAS2562 amplifier binding Dan Murphy
2019-10-08 18:15 ` [alsa-devel] [PATCH 2/2] ASoC: tas2562: Introduce the TAS2562 amplifier Dan Murphy
2019-10-15 20:09 ` Rikard Falkeborn [this message]
2019-10-18 18:06 ` [alsa-devel] Applied "ASoC: tas2562: Fix misuse of GENMASK macro" to the asoc tree Mark Brown
2019-10-09 17:21 ` [alsa-devel] Applied "ASoc: Add Texas Instruments TAS2562 amplifier binding" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015200900.25798-1-rikard.falkeborn@gmail.com \
--to=rikard.falkeborn@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dmurphy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox