From: Greg KH <greg@kroah.com>
To: Richard Leitner <richard.leitner@skidata.com>
Cc: alsa-devel@alsa-project.org,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
linux-kernel@vger.kernel.org, tiwai@suse.com,
stable@vger.kernel.org, lgirdwood@gmail.com,
Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
Igor Opaniuk <igor.opaniuk@toradex.com>,
broonie@kernel.org, festevam@gmail.com
Subject: Re: [alsa-devel] [PATCH v5.3] ASoC: sgtl5000: add ADC mute control
Date: Wed, 16 Oct 2019 14:16:54 -0700 [thread overview]
Message-ID: <20191016211654.GB856391@kroah.com> (raw)
In-Reply-To: <20191016091304.15870-1-richard.leitner@skidata.com>
On Wed, Oct 16, 2019 at 11:13:04AM +0200, Richard Leitner wrote:
> From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
>
> Upstream commit 631bc8f0134a ("ASoC: sgtl5000: Fix of unmute outputs on
> probe"), which is e9f621efaebd in v5.3 replaced snd_soc_component_write
> with snd_soc_component_update_bits and therefore no longer cleared the
> MUTE_ADC flag. This caused the ADC to stay muted and recording doesn't
> work any longer. This patch fixes this problem by adding a Switch control
> for MUTE_ADC.
>
> commit 694b14554d75 ("ASoC: sgtl5000: add ADC mute control") upstream
>
> This control mute/unmute the ADC input of SGTL5000
> using its CHIP_ANA_CTRL register.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Reviewed-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Link: https://lore.kernel.org/r/20190719100524.23300-5-oleksandr.suvorov@toradex.com
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> Fixes: e9f621efaebd ("ASoC: sgtl5000: Fix of unmute outputs on probe")
> ---
> sound/soc/codecs/sgtl5000.c | 1 +
> 1 file changed, 1 insertion(+)
Now applied, thanks.
greg k-h
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-10-16 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 9:13 [alsa-devel] [PATCH v5.3] ASoC: sgtl5000: add ADC mute control Richard Leitner
2019-10-16 21:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016211654.GB856391@kroah.com \
--to=greg@kroah.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=igor.opaniuk@toradex.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=oleksandr.suvorov@toradex.com \
--cc=richard.leitner@skidata.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox