From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-samsung-soc@vger.kernel.org, alsa-devel@alsa-project.org,
Sangbeom Kim <sbkim73@samsung.com>,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH 21/36] ARM: s3c: move iis pinctrl config into boards
Date: Wed, 23 Oct 2019 14:50:53 +0200 [thread overview]
Message-ID: <20191023125053.GF11048@pi3> (raw)
In-Reply-To: <20191010203043.1241612-21-arnd@arndb.de>
On Thu, Oct 10, 2019 at 10:30:05PM +0200, Arnd Bergmann wrote:
> The s3c_gpio_cfgall_range() function is an internal interface of
> the samsung gpio driver and should not be called directly by drivers,
> so move the iis pin initialization into the boards.
>
> Note that the s3c2412-i2s driver has no boards using it in
> mainline linux, the driver gets selected for the jive machine
> but is never instantiated.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-s3c24xx/mach-gta02.c | 4 ++++
> arch/arm/mach-s3c24xx/mach-h1940.c | 3 +++
> arch/arm/mach-s3c24xx/mach-mini2440.c | 5 +++++
> arch/arm/mach-s3c24xx/mach-n30.c | 5 +++++
> arch/arm/mach-s3c24xx/mach-nexcoder.c | 5 +++++
> arch/arm/mach-s3c24xx/mach-otom.c | 6 ++++++
> arch/arm/mach-s3c24xx/mach-qt2410.c | 3 +++
> arch/arm/mach-s3c24xx/mach-rx1950.c | 3 +++
> arch/arm/mach-s3c24xx/mach-rx3715.c | 4 ++++
> arch/arm/mach-s3c24xx/mach-smdk2410.c | 5 +++++
> arch/arm/mach-s3c24xx/mach-smdk2413.c | 4 ++++
> arch/arm/mach-s3c24xx/mach-smdk2440.c | 6 +++++-
> arch/arm/mach-s3c24xx/mach-vstms.c | 6 +++++-
> arch/arm/mach-s3c24xx/simtec-audio.c | 6 ++++++
> sound/soc/samsung/s3c2412-i2s.c | 7 -------
> sound/soc/samsung/s3c24xx-i2s.c | 7 -------
> 16 files changed, 63 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/mach-gta02.c b/arch/arm/mach-s3c24xx/mach-gta02.c
> index 526fd0933289..1ca0460d82f4 100644
> --- a/arch/arm/mach-s3c24xx/mach-gta02.c
> +++ b/arch/arm/mach-s3c24xx/mach-gta02.c
> @@ -540,6 +540,10 @@ static void __init gta02_machine_init(void)
>
> i2c_register_board_info(0, gta02_i2c_devs, ARRAY_SIZE(gta02_i2c_devs));
>
> + /* Configure the I2S pins (GPE0...GPE4) in correct mode */
> + s3c_gpio_cfgall_range(S3C2410_GPE(0), 5, S3C_GPIO_SFN(2),
> + S3C_GPIO_PULL_NONE);
This is not entirely equivalent move as before this was probe (so being
executed also on rebinds) and now it is init. I guess it should not make
any difference so let it be.
Best regards,
Krzysztof
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-23 12:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 20:28 [alsa-devel] [PATCH 00/36] ARM: samsung platform cleanup Arnd Bergmann
[not found] ` <20191010203043.1241612-1-arnd@arndb.de>
2019-10-10 20:29 ` [alsa-devel] [PATCH 11/36] ARM: s5pv210: split from plat-samsung Arnd Bergmann
2019-10-11 5:51 ` Uwe Kleine-König
2019-10-22 14:01 ` Arnd Bergmann
2019-10-22 15:53 ` Uwe Kleine-König
2019-10-22 16:20 ` Arnd Bergmann
2019-10-15 14:13 ` Ulf Hansson
2019-10-15 14:23 ` Thierry Reding
2019-10-23 12:14 ` Krzysztof Kozlowski
2019-10-23 13:17 ` Arnd Bergmann
2019-10-23 14:12 ` Krzysztof Kozlowski
2019-10-10 20:30 ` [alsa-devel] [PATCH 17/36] ARM: s3c: h1940-audio: turn into platform driver Arnd Bergmann
2019-10-10 20:30 ` [alsa-devel] [PATCH 18/36] ARM: s3c: gta02-audio: " Arnd Bergmann
2019-10-10 20:30 ` [alsa-devel] [PATCH 19/36] ARM: s3c: rx1950: " Arnd Bergmann
2019-10-10 20:30 ` [alsa-devel] [PATCH 20/36] ASoC: samsung: s3c2412-i2s: avoid hardcoded S3C2410_PA_IIS Arnd Bergmann
2019-10-11 10:50 ` Mark Brown
2019-10-10 20:30 ` [alsa-devel] [PATCH 21/36] ARM: s3c: move iis pinctrl config into boards Arnd Bergmann
2019-10-23 12:50 ` Krzysztof Kozlowski [this message]
2019-10-23 13:29 ` Arnd Bergmann
2019-10-23 13:10 ` [alsa-devel] [PATCH 00/36] ARM: samsung platform cleanup Krzysztof Kozlowski
2019-10-23 13:39 ` Arnd Bergmann
2019-10-23 15:17 ` Lihua Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023125053.GF11048@pi3 \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=kgene@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox