From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ECA5CA9EA0 for ; Fri, 25 Oct 2019 16:23:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 988152070B for ; Fri, 25 Oct 2019 16:23:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Jc5bLxas" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 988152070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9DEFA184A; Fri, 25 Oct 2019 18:22:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9DEFA184A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572020610; bh=/xXnk2kuG88dFi+ylO14FIlMM/jKu/eGNe5NOXWh0GQ=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Jc5bLxasSbi5UP561p39br9to/0hydjYWQPiOEtGXOvNzlCplFSNr5YPjHt1OCjK0 ujwlEQTVFUEP/Cjeh31glF34B4WbhXciczp7nAfCcprd9GfKVNBGraNGM5e9zFSdK/ 0bF1S+mM9NA7SeizdM5Iapnmjp2Exv8NcjAuoyHg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2E26AF80368; Fri, 25 Oct 2019 18:22:40 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6D63DF8036F; Fri, 25 Oct 2019 18:22:39 +0200 (CEST) Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7B683F802A0 for ; Fri, 25 Oct 2019 18:22:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7B683F802A0 Received: by mail-ot1-f67.google.com with SMTP id 41so2414609oti.12 for ; Fri, 25 Oct 2019 09:22:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DcXI0ptEmLNRJ3ATloq3LFD9nbZMbeqbCJ87LxNGHWo=; b=SJTZDJi+9fAQ2ogEePOSNdJ1pLr6f4ZnhsjxisDpG2fwG/9gyfy/4pALzHLKSmh+aO eqbl8B6w5w4/wCrtmJ7md8mVHL/djccF9bSeb5ZSkCEW5PtBBkLtwGQ186yqlo6SXcJ2 4qZneCn+t1maE7wrYfKDltKVXv1nQZ3W91CtKZJT0KF5ccjr4ZQkOAMZj5TIoH4mACcw PFoKtQlrfNpCfE/Yx0Hk7sMczTOg1ii9EnX1VnTBInILCv82bnxHfg+80z7I5gIdPe4l 5X3AdD9CLeZB9uxI/bV2b/JsQVL43+rcrT5BXpBic+S3qVv/LBi8x4zTT3XQvLaS3po2 /l2w== X-Gm-Message-State: APjAAAW0l/fe1gzmNVnYE1GbXHkEGn9TQe1NpxmNp3qhz8dEtFyoELZL UKpXQcB9dC2lP9Vt5eGb5A== X-Google-Smtp-Source: APXvYqzzIuc1vcdp++0F80RLl8KAdKlip2Nqm2Fe6QaByRNOoVA8SwaqBnoVkTda+L/6FQKAQI1xRg== X-Received: by 2002:a9d:3476:: with SMTP id v109mr3516135otb.211.1572020554577; Fri, 25 Oct 2019 09:22:34 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id i5sm836976otk.10.2019.10.25.09.22.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2019 09:22:33 -0700 (PDT) Date: Fri, 25 Oct 2019 11:22:32 -0500 From: Rob Herring To: Cheng-Yi Chiang Message-ID: <20191025162232.GA23022@bogus> References: <20191025133007.11190-1-cychiang@chromium.org> <20191025133007.11190-3-cychiang@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191025133007.11190-3-cychiang@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Mark Rutland , alsa-devel@alsa-project.org, Heiko Stuebner , Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hans Verkuil , Andrzej Hajda , Laurent Pinchart , Jerome Brunet , Takashi Iwai , linux-rockchip@lists.infradead.org, dgreid@chromium.org, devicetree@vger.kernel.org, tzungbi@chromium.org, Jonas Karlman , Liam Girdwood , Russell King , Mark Brown , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , dianders@chromium.org, Daniel Vetter Subject: Re: [alsa-devel] [PATCH v8 2/6] ASoC: rockchip-max98090: Support usage with and without HDMI X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Oct 25, 2019 at 09:30:03PM +0800, Cheng-Yi Chiang wrote: > There will be multiple boards sharing this machine driver. > Use compatible string to specify the use case. > > "rockchip,rockchip-audio-max98090" for max98090-only. > "rockchip,rockchip-audio-hdmi" for HDMI-only > "rockchip,rockchip-audio-max98090-hdmi" for max98090 plus > > Move these properties to optional because they are not needed for > HDMI-only use case. > "rockchip,audio-codec": The phandle of the MAX98090 audio codec > "rockchip,headset-codec": The phandle of Ext chip for jack detection > > The machine driver change will add support for HDMI codec in > rockchip-max98090. > Add one optional property "rockchip,hdmi-codec" to let user specify HDMI > device node in DTS so machine driver can find hdmi-codec device node for > codec DAI. Why not just use the presence of rockchip,hdmi-codec to enable HDMI or not. Maybe you still add rockchip,rockchip-audio-hdmi for HDMI only. Really, the same should have been done for which codec is used too, but I guess someone wanted 2 machine drivers. > > Signed-off-by: Cheng-Yi Chiang > --- > .../bindings/sound/rockchip-max98090.txt | 38 +++++++++++++++++-- > 1 file changed, 35 insertions(+), 3 deletions(-) _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel