From: Mark Brown <broonie@kernel.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: ALSA development <alsa-devel@alsa-project.org>,
Jimmy Cheng-Yi Chiang <cychiang@google.com>,
Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
jarkko.nikula@linux.intel.com, Benson Leung <bleung@google.com>,
Dylan Reid <dgreid@google.com>, Hsin-yu Chao <hychao@google.com>
Subject: Re: [alsa-devel] Questions about max98090 codec driver
Date: Mon, 28 Oct 2019 12:14:50 +0000 [thread overview]
Message-ID: <20191028121450.GD5015@sirena.co.uk> (raw)
In-Reply-To: <CA+Px+wU0MAJVbS42X5J=RhDoz4C1M5VcW0kV0ji73sBtMM6omA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 563 bytes --]
On Fri, Oct 25, 2019 at 01:09:06PM +0800, Tzung-Bi Shih wrote:
> On Fri, Oct 25, 2019 at 3:14 AM Mark Brown <broonie@kernel.org> wrote:
> > Wow, that's a bit special. I'm wondering if the PLL unlock error
> > handling isn't connected to the PLL configuration?
> I don't quite understand here. Did you mean: when max98090_pll_work()
> get called, the PLL may have locked. The code doesn't check
> M98090_REG_DEVICE_STATUS but shutdown and on anyway. In the case
> max98090 may generate a new interrupt and again and again?
Something along those lines yeah.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-28 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 18:23 [alsa-devel] Questions about max98090 codec driver Tzung-Bi Shih
2019-10-24 19:14 ` Mark Brown
2019-10-25 5:09 ` Tzung-Bi Shih
2019-10-28 12:14 ` Mark Brown [this message]
2019-10-24 19:25 ` Pierre-Louis Bossart
2019-10-25 11:49 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028121450.GD5015@sirena.co.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bleung@google.com \
--cc=cychiang@google.com \
--cc=dgreid@google.com \
--cc=hychao@google.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox