From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A3D6C432C0 for ; Fri, 22 Nov 2019 00:25:34 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93063206D7 for ; Fri, 22 Nov 2019 00:25:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="D6Mg58jt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93063206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=b4.vu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6F8F217AC; Fri, 22 Nov 2019 01:24:40 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6F8F217AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1574382330; bh=7RhxjmUvtg/J0sJgC7iT11aB8hBJ1lavfSEJ7FThOKo=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=D6Mg58jtqUCTp+WiiS1qVltLvYuc0QXDrFEfZS1+N5tYRF2MS/+NK2kQKkQ6q7Pxp ppDlN5+1wz/pOPet0lULzpBc+fbvhWBptmRTI5b34Rlc/x1q/T4Gsfy5vTI6Vo8eon n3NDMUfjaat7f23yiYJJSjo+xznZxv+wHte85aQQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E4CB9F800C1; Fri, 22 Nov 2019 01:24:39 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B2619F80146; Fri, 22 Nov 2019 01:24:38 +0100 (CET) Received: from b4.vu (b4.vu [203.16.231.147]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BC171F800C1 for ; Fri, 22 Nov 2019 01:24:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BC171F800C1 Received: from b4.vu (localhost.localdomain [127.0.0.1]) by b4.vu (8.13.8/8.13.8) with ESMTP id xAM0OSHv022853; Fri, 22 Nov 2019 10:54:28 +1030 Received: (from g@localhost) by b4.vu (8.13.8/8.13.8/Submit) id xAM0OR1U022852; Fri, 22 Nov 2019 10:54:27 +1030 Date: Fri, 22 Nov 2019 10:54:27 +1030 From: "Geoffrey D. Bennett" To: Takashi Iwai Message-ID: <20191122002427.GD18019@b4.vu> References: <20191111054133.GA1817@b4.vu> <861b90c8-8878-c3be-bc8e-769a3638cc14@gmail.com> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Cc: Markus Schroetter , alsa-devel@alsa-project.org Subject: Re: [alsa-devel] [PATCH] ALSA: usb-audio: Fix Scarlett 6i6 Gen 2 port data X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Nov 21, 2019 at 05:06:42PM +0100, Takashi Iwai wrote: > On Thu, 21 Nov 2019 09:52:10 +0100, > Markus Schroetter wrote: > > > > > The s6i6_gen2_info.ports[] array had the Mixer and PCM port type > > > entries in the wrong place. Use designators to explicitly specify the > > > array elements being set. > > > > > > Fixes: 9e4d5c1be21f ("ALSA: usb-audio: Scarlett Gen 2 mixer interface") > > > Signed-off-by: Geoffrey D. Bennett > > > > Reported-by: Jonas Berlin > > > > Tested-by: Alex Fellows > > > Tested-by: Markus Schroetter > > Oh this wasn't taken yet. Now merged for 5.5. Thanks for that! Is it possible to get it included in 5.4.1 as well? Without this patch, the 6i6 support is unusable. Thanks, Geoffrey. _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel