From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F566C432C0 for ; Wed, 27 Nov 2019 06:41:46 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2514020409 for ; Wed, 27 Nov 2019 06:41:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="rBFZ5WwO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CvVd5h8y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2514020409 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 60960172E; Wed, 27 Nov 2019 07:40:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 60960172E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1574836904; bh=Oyc1j6ZXQsdNIH6+zijMkBmezlrAfs2FMqrvt1uxMLU=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rBFZ5WwO2yqAzRYqvu5h1J2K/laRsLzZicSIeaXuUwJjD6Zk7synLNSrfmPXAU216 oM9O2pTPBft56L26RmZhXyRC1xWekRsrnogWKp9+l685Ual61WJKmwBno8Xj8UkdML bL5MwejxEnNkkQO7Q6BKsEC4oQp+FO7XQTCI8edI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 693A3F80213; Wed, 27 Nov 2019 07:39:15 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9FE90F800DD; Tue, 26 Nov 2019 12:16:25 +0100 (CET) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 23FA4F80149 for ; Tue, 26 Nov 2019 12:16:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 23FA4F80149 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CvVd5h8y" Received: by mail-wr1-x441.google.com with SMTP id z3so21947691wru.3 for ; Tue, 26 Nov 2019 03:16:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mPsIQyZB05XA1geV+/a9mGk6poY26Jzmyx/vRU1WfpY=; b=CvVd5h8yRpWWCZspKyZ2Geub44N8W7U4Jhjye1wj0+gjwAtkOVVmcul2n5Td6FtIOl TYG086TBeCaeOdVzPpwKhwlLc4pXmhKLeWtbE6m/dAKdho1uQ2gr6EZUmN0OfCnHu7vA CkekA1Jm7ugM9uREG/GBYK687qdaWRWRkE+2whjefu8rgH7tRkaaT/cLei9WaenddzQB YDNEo0bfRrPSjq0dSg9yxZszaBpoL3x1/rChO+3ehiBgMCnr9nBa16a76NKGQ4BuO449 +5/bTc4kSISupGE5hditCGRORIPgm4bURLWXT4/8PYFGt4EyUpjU1VnqY7G7PQD752dr 4Cxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=mPsIQyZB05XA1geV+/a9mGk6poY26Jzmyx/vRU1WfpY=; b=GS1YVIUAT0V0I1zHnSz7NewyTPyUogxeOVAXW9ID5esb/Sr7TgrBkfYFSvM+lNHF1M 5l17Km79+a6MZgAaZbster68ALUfCq9ubcUhWnEbJ2OhGqxN2WPyKOPaq7beKSENpYqB Zd5BEkKTPxjbAq7o25ZIhOl69muc69w+mwQOQQILiede168239k7JnVvYKOZ5w1Xn7jM 9+kU/Jv7xh0CtLS3EzHLvO95YUXJPjNbxNxua+dLZHSdWH1X9JgnFQVwKdkw0xLb+RZ3 +jxwAcKxqIN7l5tl/lPSLubsW/43UwZZ7oxguk27j0YlfjsU78BRuXLCJ4tfpVxs/u15 RjnQ== X-Gm-Message-State: APjAAAVdgLsxcpyxOylnreJiUfLHEO5IkITcV/qHinBc7EDjOfMJHnrZ UeKrS2g+VmtGZxNdLqCGG00= X-Google-Smtp-Source: APXvYqxSB1tYKQQzsIwE/RCW4zstGtQNypAFngwnyjSt5EMF0PfBQcHF962Sesm4cfpD/IFXIDsxsQ== X-Received: by 2002:adf:ef49:: with SMTP id c9mr16155700wrp.292.1574766982078; Tue, 26 Nov 2019 03:16:22 -0800 (PST) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id b14sm2692135wmj.18.2019.11.26.03.16.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 03:16:21 -0800 (PST) Date: Tue, 26 Nov 2019 12:16:18 +0100 From: Ingo Molnar To: Sean Christopherson Message-ID: <20191126111618.GA28423@gmail.com> References: <20191119002121.4107-1-sean.j.christopherson@intel.com> <20191119002121.4107-12-sean.j.christopherson@intel.com> <7338293.UcAxln0NAJ@kreacher> <20191125104803.v6goacte2vjakx64@ucw.cz> <20191125170034.GB12178@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191125170034.GB12178@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Wed, 27 Nov 2019 07:39:10 +0100 Cc: Mark Rutland , Cezary Rojewski , linux-efi@vger.kernel.org, linux-ia64@vger.kernel.org, Fenghua Yu , Peter Zijlstra , Jie Yang , alsa-devel@alsa-project.org, Liam Girdwood , Nadav Amit , Pavel Machek , "H. Peter Anvin" , Jiri Olsa , Ard Biesheuvel , linux-acpi@vger.kernel.org, x86@kernel.org, Pierre-Louis Bossart , "VMware, Inc." , Ingo Molnar , Darren Hart , Len Brown , Arnd Bergmann , linux-pm@vger.kernel.org, Arnaldo Carvalho de Melo , Hans de Goede , Mark Brown , Borislav Petkov , Steven Rostedt , Namhyung Kim , Thomas Gleixner , platform-driver-x86@vger.kernel.org, Tony Luck , Greg Kroah-Hartman , "Rafael J. Wysocki" , Takashi Iwai , Alexander Shishkin , linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [alsa-devel] [PATCH 11/12] ACPI/sleep: Convert acpi_wakeup_address into a function X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" * Sean Christopherson wrote: > On Mon, Nov 25, 2019 at 11:48:03AM +0100, Pavel Machek wrote: > > > On Tuesday, November 19, 2019 1:21:20 AM CET Sean Christopherson wrote: > > > > Convert acpi_wakeup_address from a raw variable into a function so that > > > > x86 can wrap its dereference of the real mode boot header in a function > > > > instead of broadcasting it to the world via a #define. This sets the > > > > stage for a future patch to move the definition of acpi_wakeup_address() > > > > out of asm/acpi.h and thus break acpi.h's dependency on asm/realmode.h. > > > > > > > > No functional change intended. > > > > > > > > Signed-off-by: Sean Christopherson > > > > > > Acked-by: Rafael J. Wysocki > > > > > > > --- a/drivers/acpi/sleep.c > > > > +++ b/drivers/acpi/sleep.c > > > > @@ -63,9 +63,9 @@ static int acpi_sleep_prepare(u32 acpi_state) > > > > #ifdef CONFIG_ACPI_SLEEP > > > > /* do we have a wakeup address for S2 and S3? */ > > > > if (acpi_state == ACPI_STATE_S3) { > > > > - if (!acpi_wakeup_address) > > > > + if (!acpi_wakeup_address()) > > > > return -EFAULT; > > > > - acpi_set_waking_vector(acpi_wakeup_address); > > > > + acpi_set_waking_vector(acpi_wakeup_address()); > > > > > > > > You might want to store result in a variable... especially since you are > > turning inline function into real one in a next patch. > > > > And maybe function should be called get_acip_wakeup_address or > > something? This way it is easy to mistake actual wakeup address from > > function that gets it... > > Agreed on both counts. > > > Ingo, > > Would you prefer a v2 of the entire series (with Acks and removal of Fixes), > or a v2 that includes only the last two patches? Yep, that would be handy. I have them committed to tip:core/headers, but haven't sent it to Linus yet, and can redo that all with these improvements. Thanks, Ingo _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel