From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DF70C2D0C5 for ; Wed, 11 Dec 2019 11:43:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D60932073D for ; Wed, 11 Dec 2019 11:43:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="kWh22jNT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Br0+MtwR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D60932073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 05C721615; Wed, 11 Dec 2019 12:43:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 05C721615 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1576064635; bh=pq9aP5bGcs0Ec/6v4gi7GG+fL62LonoLnv4+ZwZjnnk=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kWh22jNT6b/x6XridyBYnGZrevrFZ/h8t6PcVLzlGoAdo1Z79wmprGFe3JhaPRJde +WlMSC6H5lDVK1ufekUYiVJUjxQHXve+P2IWBy1k0HoKd7f1UciahcEAHrU71qx1wn McXHCLEBS5avvwlDloHZRI/Vhd94UYf1jlyVpwyA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7B033F8019B; Wed, 11 Dec 2019 12:43:04 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9D59AF801F4; Wed, 11 Dec 2019 12:43:02 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 47B87F8011E for ; Wed, 11 Dec 2019 12:42:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 47B87F8011E Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Br0+MtwR" Received: from localhost (unknown [171.76.100.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 443762073D; Wed, 11 Dec 2019 11:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576064573; bh=6KjxzfVLAoUXt6yCuyJGQsbZXfDjjfZdoEGj/7xAFwU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Br0+MtwRTdi/snyt2rZP3odMEKcpSeZx4LJlZzqmw+Uyfbg7u4G4oboGukomiSde4 1ygUsRc54BqDgNjRvPo9aMALRrsBLLjLKyYR9mKkDOnGfMZNooeoRh04fSGZkarPEu C3HAGZHiXfjxDg1J4HS2/ut/zLfftTwYsnL/o2vg= Date: Wed, 11 Dec 2019 17:12:47 +0530 From: Vinod Koul To: Pierre-Louis Bossart Message-ID: <20191211114247.GI2536@vkoul-mobl> References: <20191209235520.18727-1-pierre-louis.bossart@linux.intel.com> <20191209235520.18727-6-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191209235520.18727-6-pierre-louis.bossart@linux.intel.com> Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Ranjani Sridharan , broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale , Bard liao , Rander Wang Subject: Re: [alsa-devel] [PATCH v4 05/11] soundwire: intel: update interfaces between ASoC and SoundWire X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 09-12-19, 17:55, Pierre-Louis Bossart wrote: > @@ -138,8 +126,6 @@ static struct sdw_intel_ctx > pdevinfo.name = "int-sdw"; > pdevinfo.id = i; > pdevinfo.fwnode = acpi_fwnode_handle(adev); > - pdevinfo.data = &link->res; > - pdevinfo.size_data = sizeof(link->res); > > pdev = platform_device_register_full(&pdevinfo); > if (IS_ERR(pdev)) { > @@ -224,10 +210,8 @@ EXPORT_SYMBOL(sdw_intel_init); This is still exported > struct sdw_intel_res { > + int count; > void __iomem *mmio_base; > int irq; > acpi_handle handle; > struct device *parent; > const struct sdw_intel_ops *ops; > - void *arg; > + struct device *dev; > + u32 link_mask; > }; > > -void *sdw_intel_init(acpi_handle *parent_handle, struct sdw_intel_res *res); But prototype removed, so i think this is a miss in the series, can you fix that up -- ~Vinod _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel