From: Mark Brown <broonie@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
alsa-devel@alsa-project.org, festevam@gmail.com,
Igor Opaniuk <igor.opaniuk@toradex.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: sgtl5000: Fix VDDA and VDDIO comparison
Date: Fri, 20 Dec 2019 13:00:30 +0000 [thread overview]
Message-ID: <20191220130030.GE4790@sirena.org.uk> (raw)
In-Reply-To: <20191219213257.366145-1-marex@denx.de>
[-- Attachment #1.1: Type: text/plain, Size: 286 bytes --]
On Thu, Dec 19, 2019 at 10:32:57PM +0100, Marek Vasut wrote:
> #include "sgtl5000.h"
>
> +#include "../../../drivers/regulator/internal.h"
> +
This sort of peering inside the internals of the framework is obviously
not OK, please add an interface for this if it's needed.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-12-20 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 21:32 [alsa-devel] [PATCH] ASoC: sgtl5000: Fix VDDA and VDDIO comparison Marek Vasut
2019-12-20 13:00 ` Mark Brown [this message]
2019-12-20 13:01 ` Marek Vasut
2019-12-20 13:02 ` Mark Brown
2019-12-20 13:10 ` Marek Vasut
2019-12-20 16:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220130030.GE4790@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=festevam@gmail.com \
--cc=igor.opaniuk@toradex.com \
--cc=marcel.ziswiler@toradex.com \
--cc=marex@denx.de \
--cc=oleksandr.suvorov@toradex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox