From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Rosen Penev <rosenp@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH] xfer-opitons: Fix -Wformat=2 warnings
Date: Tue, 24 Dec 2019 19:13:35 +0900 [thread overview]
Message-ID: <20191224101335.GB28396@workstation> (raw)
In-Reply-To: <20191222025458.745140-1-rosenp@gmail.com>
On Sat, Dec 21, 2019 at 06:54:58PM -0800, Rosen Penev wrote:
> Allows the compiler to check types.
>
> format string functions expect constant expressions, not constant
> variables.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> axfer/xfer-options.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
Reviewd-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
According to reference manual of GCC[1], '-Wformat=2' is a easy helper to
enable below options:
* -Wformat
* -Wformat-nonliteral
* -Wformat-security
* -Wformat-y2k
Your fix suppresses the warning from '-Wformat-nonliteral'. I'd like
maintainers to revise the title of patch.
[1] https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
Regards
Takashi Sakamoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2019-12-24 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-22 2:54 [alsa-devel] [PATCH] xfer-opitons: Fix -Wformat=2 warnings Rosen Penev
2019-12-24 10:13 ` Takashi Sakamoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224101335.GB28396@workstation \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox